Feature Additions #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relative filepath fixes
dshafik
pushed a commit
to dshafik/xhprof
that referenced
this pull request
Oct 23, 2013
fix for PHP 5.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've only just started looking at this project after your discussion of it at PHPCon. Here are the first few things I've found myself wanting after getting it setup.
Firstly, I've fleshed out the install doc a bit and corrected a few things in it. When installing it I found that I was going back and forth between several different guides to get all the relevant details.
Next, I added the ability to ignore certian URLs because on the project I am working on we have a few background ajax calls that will quickly fill up the list. Another possible solution to this would be to collapse multiple calls in succession in to a single expandable row. Or maybe a combination of the both.
Lastly, I added the ability to display more than 50 Runs. I added a link for displaying All runs and a form for specifying a number of runs to display. I might also write a paginator in soon.