Remote Address behind proxies/cdn's #101
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
October 10, 2016 20:35
…rds compatibility
|
For some reason the other commits are also mentioned, although they are already merged, I probably did something wrong, but still, the only file being modified is the external/header |
aik099
reviewed
Oct 18, 2016
| @@ -51,7 +51,28 @@ public static function __callstatic($name, $arguments) | |||
| } | |||
|
|
|||
| // Only users from authorized IP addresses may control Profiling | |||
| if ($controlIPs === false || in_array($_SERVER['REMOTE_ADDR'], $controlIPs) || PHP_SAPI == 'cli') | |||
| function get_client_ip() { | |||
| $ipaddress = ''; | |||
There was a problem hiding this comment.
- Are all these headers really need to be checked?
- Blindly trusting IP provided in these headers actually open a security hole, where an attacker can put needed IP in a header and force website to run slower due fact, that xhprof is collecting analytics data. And in fact it will print profiling link back to attacker, which in turn would reveal some sensitive info about website itself.
|
There is also something wrong with commit you've used to create the PR branch, because surely you haven't made 9 commits just to create 1 function. Rebasing and force pushing would help in this case. And I've just tried to rebase and got some conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is my suggested fix for Issue #100
Please review and check if it suits the project.
Thanks x)