Add explicit browserslist config #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phra
requested changes
May 23, 2018
package.json
Outdated
| @@ -51,5 +51,15 @@ | |||
| "style-loader": "^0.13.0", | |||
| "webpack": "2.2.0", | |||
| "webpack-dev-server": "2.2.0" | |||
| }, | |||
| "browserslist": { | |||
There was a problem hiding this comment.
can you create instead a .browserslistrc file in the root instead of updating package.json?
dkokic
force-pushed
the
fix/add-browserslist-config
branch
from
a444ec2
to
72c2fa9
Compare
|
Done. |
phra
requested changes
May 24, 2018
.browserslistrc
Outdated
| "last 1 chrome version", | ||
| "last 1 firefox version" | ||
| ] | ||
| } |
There was a problem hiding this comment.
the syntax for .browserslistsrc is different from package.json` one. see https://www.npmjs.com/package/browserslist#environments and update the PR.
dkokic
force-pushed
the
fix/add-browserslist-config
branch
from
72c2fa9
to
33ab76b
Compare
dkokic
force-pushed
the
fix/add-browserslist-config
branch
from
33ab76b
to
327cfd4
Compare
|
ups ;-)
…On 24 May 2018 at 17:20, Francesco Soncina ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In .browserslistrc
<#99 (comment)>
:
> @@ -0,0 +1,10 @@
+{
+ "production": [
+ "> 1%",
+ "ie 10"
+ ],
+ "development": [
+ "last 1 chrome version",
+ "last 1 firefox version"
+ ]
+}
the syntax for .browserslistsrc is different frompackage.json` one. see
https://www.npmjs.com/package/browserslist#environments and update the PR.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#99 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANDjjlE_HUS3EuP9v4xTV4FawzsPgrfks5t1s-qgaJpZM4Tz-k1>
.
|
phra
approved these changes
May 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As browserslist is already being used by autoprefixer here the explicit (recommended) config in package.json
Should help resolve #91 (and consequently #95)