Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core): use object.assign to test the trade-off between size and perf #4365

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore(core): use object.assign to test the trade-off between size and perf #4365

wants to merge 2 commits into from
+5 −48

Conversation

JoviDeCroock
Copy link
Member

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 30, 2024 •
edited

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +1% (-8.98ms - +6.74ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -2% - +1% (-0.30ms - +0.12ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -0% - +2% (-0.19ms - +1.76ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -5% - +2% (-0.70ms - +0.24ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -3% - +1% (-1.76ms - +0.55ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -4% - +4% (-0.08ms - +0.09ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +1% (-0.34ms - +0.16ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -2% - +4% (-0.51ms - +1.16ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -2% - +4% (-0.31ms - +0.51ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +1% (-0.02ms - +0.03ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local904.81ms - 913.84ms-unsure 🔍
-1% - +1%
-8.98ms - +6.74ms
preact-main904.01ms - 916.87msunsure 🔍
-1% - +1%
-6.74ms - +8.98ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local27.31ms - 27.31ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-main27.31ms - 27.31msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms		-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.70ms - 16.85ms-unsure 🔍
-2% - +1%
-0.30ms - +0.12ms
preact-main16.67ms - 17.07msunsure 🔍
-1% - +2%
-0.12ms - +0.30ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.76ms - 1.76ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.76ms - 1.76msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local72.59ms - 74.41ms-unsure 🔍
-0% - +2%
-0.19ms - +1.76ms
preact-main72.36ms - 73.07msunsure 🔍
-2% - +0%
-1.76ms - +0.19ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local14.38ms - 14.95ms-unsure 🔍
-2% - +4%
-0.31ms - +0.51ms
preact-main14.27ms - 14.86msunsure 🔍
-3% - +2%
-0.51ms - +0.31ms		-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local14.46ms - 14.86ms-unsure 🔍
-5% - +2%
-0.70ms - +0.24ms
preact-main14.46ms - 15.32msunsure 🔍
-2% - +5%
-0.24ms - +0.70ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local4.94ms - 4.95ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main4.95ms - 4.95msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
replace1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local68.31ms - 69.87ms-unsure 🔍
-3% - +1%
-1.76ms - +0.55ms
preact-main68.84ms - 70.54msunsure 🔍
-1% - +3%
-0.55ms - +1.76ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.75ms - 3.79ms-unsure 🔍
-1% - +1%
-0.02ms - +0.03ms
preact-main3.75ms - 3.78msunsure 🔍
-1% - +1%
-0.03ms - +0.02ms		-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local29.44ms - 29.93ms-unsure 🔍
-0% - +2%
-0.10ms - +0.65ms
preact-main29.12ms - 29.69msunsure 🔍
-2% - +0%
-0.65ms - +0.10ms		-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local33.85ms - 35.63ms-unsure 🔍
-1% - +6%
-0.38ms - +2.05ms
preact-main33.08ms - 34.74msunsure 🔍
-6% - +1%
-2.05ms - +0.38ms		-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local25.84ms - 26.27ms-unsure 🔍
-1% - +1%
-0.25ms - +0.33ms
preact-main25.83ms - 26.21msunsure 🔍
-1% - +1%
-0.33ms - +0.25ms		-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local24.54ms - 25.30ms-unsure 🔍
-1% - +3%
-0.23ms - +0.81ms
preact-main24.27ms - 24.98msunsure 🔍
-3% - +1%
-0.81ms - +0.23ms		-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local26.85ms - 28.21ms-unsure 🔍
-4% - +4%
-0.99ms - +1.09ms
preact-main26.69ms - 28.27msunsure 🔍
-4% - +4%
-1.09ms - +0.99ms		-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local23.24ms - 24.24ms-unsure 🔍
-4% - +2%
-0.94ms - +0.47ms
preact-main23.48ms - 24.47msunsure 🔍
-2% - +4%
-0.47ms - +0.94ms		-
text-update

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.96ms - 2.09ms-unsure 🔍
-4% - +4%
-0.08ms - +0.09ms
preact-main1.96ms - 2.08msunsure 🔍
-4% - +4%
-0.09ms - +0.08ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local0.98ms - 0.98ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-main0.98ms - 0.98msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms		-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local28.27ms - 28.63ms-unsure 🔍
-1% - +1%
-0.34ms - +0.16ms
preact-main28.36ms - 28.71msunsure 🔍
-1% - +1%
-0.16ms - +0.34ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.25ms - 1.25ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.25ms - 1.26msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local29.45ms - 30.72ms-unsure 🔍
-2% - +4%
-0.51ms - +1.16ms
preact-main29.22ms - 30.31msunsure 🔍
-4% - +2%
-1.16ms - +0.51ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.74ms - 3.74ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-main3.74ms - 3.74msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 30, 2024 •
edited

Size Change: -110 B (-0.18%)

Total Size: 61.4 kB

Filename Size Change
compat/dist/compat.js 4.08 kB -11 B (-0.27%)
compat/dist/compat.module.js 4.01 kB -4 B (-0.1%)
compat/dist/compat.umd.js 4.14 kB -3 B (-0.07%)
debug/dist/debug.js 3.7 kB -4 B (-0.11%)
debug/dist/debug.module.js 3.7 kB -4 B (-0.11%)
debug/dist/debug.umd.js 3.78 kB -5 B (-0.13%)
dist/preact.js 4.63 kB -11 B (-0.24%)
dist/preact.min.js 4.66 kB -17 B (-0.36%)
dist/preact.min.module.js 4.66 kB -17 B (-0.36%)
dist/preact.min.umd.js 4.69 kB -17 B (-0.36%)
dist/preact.module.js 4.66 kB -1 B (-0.02%)
dist/preact.umd.js 4.7 kB -16 B (-0.34%)
ℹ️ View Unchanged
Filename Size
devtools/dist/devtools.js 231 B
devtools/dist/devtools.module.js 240 B
devtools/dist/devtools.umd.js 314 B
hooks/dist/hooks.js 1.55 kB
hooks/dist/hooks.module.js 1.59 kB
hooks/dist/hooks.umd.js 1.63 kB
jsx-runtime/dist/jsxRuntime.js 976 B
jsx-runtime/dist/jsxRuntime.module.js 949 B
jsx-runtime/dist/jsxRuntime.umd.js 1.06 kB
test-utils/dist/testUtils.js 453 B
test-utils/dist/testUtils.module.js 454 B
test-utils/dist/testUtils.umd.js 536 B

compressed-size-action

@coveralls
Copy link

coveralls commented Apr 30, 2024 •
edited

Coverage Status

coverage: 99.609% (-0.001%) from 99.61%
when pulling cc5457c on use-object-assign
into b7c43d9 on main.

@JoviDeCroock JoviDeCroock changed the base branch from main to breaking-changes-11 April 30, 2024 07:13
@JoviDeCroock JoviDeCroock changed the base branch from breaking-changes-11 to main May 22, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developit developit Awaiting requested review from developit

@andrewiggins andrewiggins Awaiting requested review from andrewiggins

@marvinhagemeister marvinhagemeister Awaiting requested review from marvinhagemeister

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JoviDeCroock @coveralls