Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

major(core): remove removeNode hack #4354

Open
wants to merge 4 commits into
base: breaking-changes-11
Choose a base branch
from
Open

major(core): remove removeNode hack #4354

wants to merge 4 commits into from
+25 −31

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Apr 29, 2024 •
edited

This removes our removeNode helper which was used to remove a specific DOM Node, this was only needed for IE11 which doesn't support Element.remove()

It looks like text-nodes aren't properly recongised when calling .remove()

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 29, 2024 •
edited

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +1% (-7.37ms - +7.50ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -1% - +0% (-0.15ms - +0.04ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -4% - +2% (-2.87ms - +1.31ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -4% - +3% (-0.73ms - +0.56ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +1% (-0.72ms - +0.96ms)
    preact-local vs preact-main
  • text-update: faster ✔ 0% - 6% (0.00ms - 0.10ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +1% (-0.13ms - +0.29ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -4% - +5% (-1.23ms - +1.60ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -2% - +3% (-0.29ms - +0.48ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +1% (-0.01ms - +0.03ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -0% - +7% (-0.00ms - +0.09ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local880.87ms - 893.28ms-unsure 🔍
-1% - +1%
-7.37ms - +7.50ms
preact-main882.91ms - 891.10msunsure 🔍
-1% - +1%
-7.50ms - +7.37ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local26.75ms - 26.75ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-main26.74ms - 26.76msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.64ms - 16.76ms-unsure 🔍
-1% - +0%
-0.15ms - +0.04ms
preact-main16.68ms - 16.83msunsure 🔍
-0% - +1%
-0.04ms - +0.15ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.75ms - 1.75ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.75ms - 1.75msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local72.69ms - 75.34ms-unsure 🔍
-4% - +2%
-2.87ms - +1.31ms
preact-main73.18ms - 76.41msunsure 🔍
-2% - +4%
-1.31ms - +2.87ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local14.14ms - 14.67ms-unsure 🔍
-2% - +3%
-0.29ms - +0.48ms
preact-main14.03ms - 14.58msunsure 🔍
-3% - +2%
-0.48ms - +0.29ms		-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.35ms - 17.17ms-unsure 🔍
-4% - +3%
-0.73ms - +0.56ms
preact-main16.35ms - 17.34msunsure 🔍
-3% - +4%
-0.56ms - +0.73ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local4.86ms - 4.86ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-main4.86ms - 4.86msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-
replace1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local68.10ms - 69.27ms-unsure 🔍
-1% - +1%
-0.72ms - +0.96ms
preact-main67.96ms - 69.17msunsure 🔍
-1% - +1%
-0.96ms - +0.72ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.64ms - 3.67ms-unsure 🔍
-0% - +1%
-0.01ms - +0.03ms
preact-main3.64ms - 3.66msunsure 🔍
-1% - +0%
-0.03ms - +0.01ms		-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local27.88ms - 28.45ms-unsure 🔍
-2% - +1%
-0.59ms - +0.34ms
preact-main27.93ms - 28.66msunsure 🔍
-1% - +2%
-0.34ms - +0.59ms		-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local35.44ms - 37.43ms-unsure 🔍
-0% - +7%
-0.04ms - +2.53ms
preact-main34.39ms - 36.00msunsure 🔍
-7% - +0%
-2.53ms - +0.04ms		-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local25.19ms - 25.82ms-unsure 🔍
-2% - +2%
-0.62ms - +0.44ms
preact-main25.17ms - 26.03msunsure 🔍
-2% - +2%
-0.44ms - +0.62ms		-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local23.24ms - 24.18ms-unsure 🔍
-4% - +1%
-0.94ms - +0.29ms
preact-main23.64ms - 24.42msunsure 🔍
-1% - +4%
-0.29ms - +0.94ms		-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local29.17ms - 30.88ms-unsure 🔍
-4% - +3%
-1.32ms - +0.90ms
preact-main29.53ms - 30.94msunsure 🔍
-3% - +4%
-0.90ms - +1.32ms		-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local23.25ms - 24.31ms-unsure 🔍
-2% - +4%
-0.52ms - +0.92ms
preact-main23.10ms - 24.07msunsure 🔍
-4% - +2%
-0.92ms - +0.52ms		-
text-update

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.69ms - 1.76ms-faster ✔
0% - 6%
0.00ms - 0.10ms
preact-main1.74ms - 1.81msunsure 🔍
-0% - +6%
+0.00ms - +0.10ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.19ms - 1.26ms-unsure 🔍
-0% - +7%
-0.00ms - +0.09ms
preact-main1.15ms - 1.22msunsure 🔍
-7% - +0%
-0.09ms - +0.00ms		-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local28.23ms - 28.56ms-unsure 🔍
-0% - +1%
-0.13ms - +0.29ms
preact-main28.18ms - 28.45msunsure 🔍
-1% - +0%
-0.29ms - +0.13ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.25ms - 1.25ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-main1.25ms - 1.25msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms		-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local32.32ms - 34.22ms-unsure 🔍
-4% - +5%
-1.23ms - +1.60ms
preact-main32.03ms - 34.13msunsure 🔍
-5% - +4%
-1.60ms - +1.23ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.69ms - 3.69ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-main3.69ms - 3.69msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 29, 2024 •
edited

Size Change: -92 B (0%)

Total Size: 61 kB

Filename Size Change
dist/preact.js 4.6 kB -13 B (0%)
dist/preact.min.js 4.63 kB -17 B (0%)
dist/preact.min.module.js 4.63 kB -17 B (0%)
dist/preact.min.umd.js 4.65 kB -18 B (0%)
dist/preact.module.js 4.61 kB -12 B (0%)
dist/preact.umd.js 4.66 kB -15 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 4.09 kB 0 B
compat/dist/compat.module.js 4.01 kB 0 B
compat/dist/compat.umd.js 4.14 kB 0 B
debug/dist/debug.js 3.63 kB 0 B
debug/dist/debug.module.js 3.63 kB 0 B
debug/dist/debug.umd.js 3.71 kB 0 B
devtools/dist/devtools.js 230 B 0 B
devtools/dist/devtools.module.js 239 B 0 B
devtools/dist/devtools.umd.js 314 B 0 B
hooks/dist/hooks.js 1.55 kB 0 B
hooks/dist/hooks.module.js 1.59 kB 0 B
hooks/dist/hooks.umd.js 1.63 kB 0 B
jsx-runtime/dist/jsxRuntime.js 976 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 949 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 1.06 kB 0 B
test-utils/dist/testUtils.js 453 B 0 B
test-utils/dist/testUtils.module.js 454 B 0 B
test-utils/dist/testUtils.umd.js 536 B 0 B

compressed-size-action

@coveralls
Copy link

Coverage Status

coverage: 99.608% (-0.001%) from 99.609%
when pulling b8c5afc on remove-unmount-ie11-hack
into 613cacc on main.

@coveralls
Copy link

coveralls commented Apr 29, 2024 •
edited

Coverage Status

coverage: 99.608% (-0.001%) from 99.609%
when pulling 6ee6062 on remove-unmount-ie11-hack
into 613cacc on main.

@JoviDeCroock JoviDeCroock changed the base branch from main to breaking-changes-11 April 30, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister Awaiting requested review from marvinhagemeister

@developit developit Awaiting requested review from developit

@andrewiggins andrewiggins Awaiting requested review from andrewiggins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JoviDeCroock @coveralls