Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sddm): add chilly sddm theme #1463

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

rubiin
Copy link
Contributor

@rubiin rubiin commented May 9, 2024

Pull Request

Description

This add few sddm theme to the collection as we just have two of them
Add the chilly theme https://www.opendesktop.org/p/1240784 which is pretty neat

Please read these instructions and remove unnecessary text.

  • Try to include a summary of the changes and which issue is fixed.
  • Also include relevant motivation and context (if applicable).
  • List any dependencies that are required for this change. (e.g., packages or other PRs)
  • Provide a link if there is an issue related to this pull request. e.g., Fixes # (issue)
  • Please add Reviewers, Assignees, Labels, Projects, and Milestones to the PR. (if applicable)

Type of change

Please put an x in the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

Please put an x in the boxes that apply:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added a changelog entry.
  • I have added necessary comments/documentation to my code.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

Screenshots

(if appropriate)

Additional context

Add any other context about the problem here.

@rubiin
Copy link
Contributor Author

rubiin commented May 9, 2024

@kRHYME7

This comment was marked as outdated.

@rubiin
Copy link
Contributor Author

rubiin commented May 9, 2024

let me check

@kRHYME7
Copy link
Collaborator

kRHYME7 commented May 9, 2024

If you want you can actually test this Pr

Hyde branch --patch

select your PR

then try to run Hyde sddm theme

BTW I tried installing it but the problem is it won't load on sddm(It fallsback to the last working theme ). I can succesfully preview though

@rubiin
Copy link
Contributor Author

rubiin commented May 9, 2024

Not showing the theme option in mine now

@kRHYME7
Copy link
Collaborator

kRHYME7 commented May 9, 2024

Oopsi please update the CLI please. My recent push was not successful

@rubiin
Copy link
Contributor Author

rubiin commented May 9, 2024

Must be some issue with file names. I am trying this locally

@kRHYME7
Copy link
Collaborator

kRHYME7 commented May 9, 2024

check the review I gave.

extract it then rename the folder Chilly compress it then rename it Sddm_Chilly.

If the Files follows the Sddm_*.tar.gz convention Hyde sddm theme should find it

image

@rubiin
Copy link
Contributor Author

rubiin commented May 9, 2024

i pushed a commit should address that

@rubiin
Copy link
Contributor Author

rubiin commented May 9, 2024

Works now. I just made some minor modifications. Turns out I also have to create a kde_config.conf by which hyde does the theme switch .

@kRHYME7
Copy link
Collaborator

kRHYME7 commented May 9, 2024

image

Works now in the VM I assume the scaling issue is vm related, I do not know.

@rubiin
Copy link
Contributor Author

rubiin commented May 9, 2024

There was a height and width setting that I tweaked to match other two themes . Will undo it . That might fix it

@rubiin rubiin changed the title feat(sddm): add chilly sddm theme feat(sddm): add 3 more sddm theme May 10, 2024
@rubiin rubiin marked this pull request as draft May 10, 2024 08:36
@rubiin rubiin marked this pull request as ready for review May 10, 2024 09:05
@rubiin
Copy link
Contributor Author

rubiin commented May 10, 2024

@kRHYME7 two more themes for you to preview.
sddm-greeter --test-mode --theme /usr/share/sddm/themes/Macos

@kRHYME7
Copy link
Collaborator

kRHYME7 commented May 10, 2024

All of them works. But macOS and deepen looks small. I got x2 scaling. I think it's better to make a separate PR for each theme so we can discuss if one is fitting.

@rubiin
Copy link
Contributor Author

rubiin commented May 10, 2024

ok let me just delete the macos and deepin . We can merge the original one

@rubiin rubiin changed the title feat(sddm): add 3 more sddm theme feat(sddm): add chilly sddm theme May 10, 2024
@rubiin
Copy link
Contributor Author

rubiin commented May 10, 2024

Done

Source/arcs/Sddm_Chilly.tar.gz Outdated Show resolved Hide resolved
Configs/.config/fastfetch/config.jsonc Outdated Show resolved Hide resolved
Scripts/install_pst.sh Show resolved Hide resolved
Copy link
Collaborator

@kRHYME7 kRHYME7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is functional, will wait for Tittu's decision in merging.

@rubiin
Copy link
Contributor Author

rubiin commented May 11, 2024

Darn I created the Pr on main branch . Couldnt create another PR till its merged :D

@Enigma1309
Copy link
Contributor

it have multi user feature?!!(looks like it has..)
If it works then i'll switch to sddm instead of gdm :)

@rubiin
Copy link
Contributor Author

rubiin commented May 11, 2024

it have multi user feature?!!(looks like it has..) If it works then i'll switch to sddm instead of gdm :)

Yeah it does have multi user. Also from the same author of sddm candy theme which is the OP theme in sddm .

@Enigma1309
Copy link
Contributor

just to make sure...
does it remember the Desktop environment per user?
(say user 1 - Hyprland , user 2 - Kde-plama)
will it auto switch to the desired DE for the user ?
(ik this is a theme merge and has nothing to do with it but still..)

@kRHYME7
Copy link
Collaborator

kRHYME7 commented May 11, 2024

Sddm still don't work like how GDM handles it.

@rubiin
Copy link
Contributor Author

rubiin commented May 11, 2024

just to make sure... does it remember the Desktop environment per user? (say user 1 - Hyprland , user 2 - Kde-plama) will it auto switch to the desired DE for the user ? (ik this is a theme merge and has nothing to do with it but still..)

not sure about that, I just found about it recently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants