Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many small fixes, changes, and improvements to configs and scripts #1453

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

Skerse
Copy link
Collaborator

@Skerse Skerse commented May 7, 2024

Pull Request

Description

This makes a lot of fixes, changes, and improvements (over 1000 lines) to the existing configs and scripts in HyDE.

Hopefully, this just makes everything cleaner, as well as fixing a few spelling and grammar mistakes. It should not change anything functionality wise for users. I also did a fix to the readme style tables as they didn't look right so that should be good now.

If anyone sees anything wrong with the changes made here, please let me know and i'll get it fixed as soon as possible.

Type of change

  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • I have added necessary comments/documentation to my code.
  • I have tested my code locally and it works as expected.

Comment on lines +333 to +350
[urgency_low]
# IMPORTANT: colors have to be defined in quotation marks.
# Otherwise the "#" and following would be interpreted as a comment.
background = "#6591A380"
foreground = "#CCF0FFE6"
frame_color = "#6591A303"
timeout = 5
# Icon for notifications with low urgency, uncomment to enable
default_icon = "$HOME/.config/dunst/icons/hyprdots.svg"

[urgency_normal]
background = "#3A4A6B80"
foreground = "#CCDDFFE6"
frame_color = "#3A4A6B03"
timeout = 5
#override_pause_level = 30
# Icon for notifications with normal urgency, uncomment to enable
default_icon = "$HOME/.config/dunst/icons/hyprdots.svg"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize we're still using hyprdots icons for dunst notifications.

I don't have the svg file to replace this, @prasanthrangan just going to let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant