New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Many small fixes, changes, and improvements to configs and scripts #1453
Open
Skerse
wants to merge
14
commits into
main
Choose a base branch
from
fixes
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skerse
commented
May 14, 2024
Comment on lines
+333
to
+350
[urgency_low] | ||
# IMPORTANT: colors have to be defined in quotation marks. | ||
# Otherwise the "#" and following would be interpreted as a comment. | ||
background = "#6591A380" | ||
foreground = "#CCF0FFE6" | ||
frame_color = "#6591A303" | ||
timeout = 5 | ||
# Icon for notifications with low urgency, uncomment to enable | ||
default_icon = "$HOME/.config/dunst/icons/hyprdots.svg" | ||
|
||
[urgency_normal] | ||
background = "#3A4A6B80" | ||
foreground = "#CCDDFFE6" | ||
frame_color = "#3A4A6B03" | ||
timeout = 5 | ||
#override_pause_level = 30 | ||
# Icon for notifications with normal urgency, uncomment to enable | ||
default_icon = "$HOME/.config/dunst/icons/hyprdots.svg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize we're still using hyprdots icons for dunst notifications.
I don't have the svg file to replace this, @prasanthrangan just going to let you know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This makes a lot of fixes, changes, and improvements (over 1000 lines) to the existing configs and scripts in HyDE.
Hopefully, this just makes everything cleaner, as well as fixing a few spelling and grammar mistakes. It should not change anything functionality wise for users. I also did a fix to the readme style tables as they didn't look right so that should be good now.
If anyone sees anything wrong with the changes made here, please let me know and i'll get it fixed as soon as possible.
Type of change
Checklist