Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rendering issues #1444

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: rendering issues #1444

wants to merge 2 commits into from

Conversation

hdm9527
Copy link
Contributor

@hdm9527 hdm9527 commented May 5, 2024

Pull Request

Description

16 inch screen resolution 2560x1600 Scaling 1.6, image rendering at wayabr height of 28 will have ghosting issues.

Type of change

Please put an x in the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

Please put an x in the boxes that apply:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added a changelog entry.
  • I have added necessary comments/documentation to my code.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

Screenshots

28 height

28-height

29 height

29-height

image url

Additional context

Add any other context about the problem here.

@zeerayne
Copy link
Contributor

zeerayne commented May 5, 2024

Actually height numbers in ctl file are generated by a script wbarstylegen.sh, and looks like if you want to change height, you should patch variable b_height in mentioned script

@hdm9527
Copy link
Contributor Author

hdm9527 commented May 5, 2024

Actually height numbers in ctl file are generated by a script wbarstylegen.sh, and looks like if you want to change height, you should patch variable b_height in mentioned script

wayabr height is read from ctl file.

image
image

@hdm9527
Copy link
Contributor Author

hdm9527 commented May 6, 2024

waybar height 29 also had problems with ghosting, and this value isn't perfect either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants