Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for swaync #1438

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

Gl00ria
Copy link
Contributor

@Gl00ria Gl00ria commented May 4, 2024

Hi, @prasanthrangan @kRHYME7 PR's ready. NOTE: it's a WIP till the integration with 'theme switching' is complete

Description:

Implementation for SwayNC in order to replace Dunst.

Type of change:

Please put an x in the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

Please put an x in the boxes that apply:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added a changelog entry.
  • I have added necessary comments/documentation to my code.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

Screenshots

Mentioned in #1023

Additional context

  1. What font you want to be used?
  2. What is the height & width standard you want? I have a big screen, so I couldn't decide :(
  3. What are the functionality you want for each button?
  4. How to edit the scripts to switch the theme correctly?

Gl00ria added 2 commits May 4, 2024 11:32
This is a WIP till the integration with 'theme switching' is complete
@Enigma1309
Copy link
Contributor

lgtm but can you add wall-bash support?

},
{
"label": "  ",
"command": "sh -c ~/.config/hypr/scripts/logoutlaunch.sh"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the script dir is changed to .local/share/bin/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm aware of that, but as I mentioned in the Additional context:

What are the functionality you want for each button

So I left it as it is for further changes

},
{
"label": " 󰃛 ",
"command": "hyprshade toggle bluefilter"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the command should be hyprshade toggle blue-light-filter

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a custom 'shader' file called 'bluefilter'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a custom shader file called 'bluefilter'

@Gl00ria
Copy link
Contributor Author

Gl00ria commented May 4, 2024

lgtm but can you add wall-bash support?

how about themeswitch.sh?

@@ -63,6 +63,9 @@ bind = $mainMod+Ctrl, P, exec, $scrPath/screenshot.sh sf # partial screenshot ca
bind = $mainMod+Alt, P, exec, $scrPath/screenshot.sh m # monitor screenshot capture
bind = , Print, exec, $scrPath/screenshot.sh p # all monitors screenshot capture

# notification center
bind = $mainMod, N, exe, swaync-client -t
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'exe' should be 'exec'.

Also, maybe this keybind should be moved to application shortcuts instead of being in its own category?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed and moved it to the app category

@abenezerw
Copy link

image
i dont know why its oversized nor detecting the style. maybe something wrong with me themes placement?

@rubiin
Copy link
Contributor

rubiin commented May 13, 2024

That clearly a bug on sizing . I was thinking of something like this
image

@Gl00ria
Copy link
Contributor Author

Gl00ria commented May 13, 2024

@abenezerw @rubiin

Height & width values can be changed form here. There is no support for dynamic sizing yet.
https://github.com/Gl00ria/hyprdots/blob/swanc_pr/Configs/.config/swaync/config.json

For the theme, I've mentioned in the Additional context that the support for theme switch is not there yet. But you can do it manually from here:
https://github.com/Gl00ria/hyprdots/blob/swanc_pr/Configs/.config/swaync/style.css

@rubiin
Copy link
Contributor

rubiin commented May 13, 2024

Theming doesnt seem to be a issue for now . The only issue is with sizing which is bound to cause issues with users

@rubiin
Copy link
Contributor

rubiin commented May 17, 2024

@Gl00ria you can take some inpirations for swaync https://github.com/AXWTV/Hyprland-DotFiles/blob/main/config/waybar/modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants