Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doas support❗ #1390

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Doas support❗ #1390

wants to merge 5 commits into from

Conversation

kRHYME7
Copy link
Collaborator

@kRHYME7 kRHYME7 commented Apr 24, 2024

Pull Request

closes 1266

doas detection and support for all the scripts.

This is a Major change, therefore this should be reviewed and inspect carefully or much better to be handled by the Owner.

USAGE:

source global first then use SUPER to either run script commands via doas || sudo

fi
}

export -f SUPER
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exported it just to be safe in case the script is nested.

@kRHYME7 kRHYME7 marked this pull request as ready for review April 24, 2024 23:40
@prasanthrangan
Copy link
Owner

cool thanks, i don't think doing minimal archinstall will include doas unless explicitly installed, but sudo is widely supported and preinstalled.
Anyways its only necessary for installation... also, maybe we can improve it by reading the password to a variable and use it for sudo/doas commands...
I'll test this later anyways :)

@rubiin
Copy link
Contributor

rubiin commented May 12, 2024

closes #1266

@noahfraiture
Copy link

What are the actual benefits of doas over sudo ? I don't know the project well but I have some doubt. Doas is significantly smaller which is a good thing, but it's also significantly newer which is a bad thing and the community using it isn't that big, theses aren't good indicator towards more security.
Also Linux doas is only a copy of openBSD doas made by other people and thus, it's again less safe to use

Is the energy needed to make the change worth it?

@kRHYME7
Copy link
Collaborator Author

kRHYME7 commented May 13, 2024

I don't really know, I only created the PR so we could have that option for users preferring doas.
I never used it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants