Minor waybar changes (dynamic lower shadowing) #1200
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 Changes into the waybar css - Feat, adding dynamic lower shadowing of waybar buttons - Fix, disable font-size to manage it size automatically the font size on multi size screen / bar size This last one is a concern when you are forced to have a different size bar on each screen (different resolution or scale).
| @@ -3,7 +3,7 @@ | |||
| border-radius: 0px; | |||
| font-family: "JetBrainsMono Nerd Font"; | |||
| font-weight: bold; | |||
| font-size: ${s_fontpx}px; | |||
| /* font-size: ${s_fontpx}px; disabled for multi monitor support */ | |||
There was a problem hiding this comment.
thank you, but the scaling is way off in my monitor when the font size is not specified!
I think this should be handled by ~/.config/waybar/config.ctl, for example when col 2 is empty, then remove this line, else if size is specified in col 2, then use that font size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 Changes into the waybar css
This last one is a concern when you are forced to have a different size bar on each screen (different resolution or scale).