Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyprlock ++ Hypridle listeners #1173

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Conversation

kRHYME7
Copy link
Collaborator

@kRHYME7 kRHYME7 commented Mar 24, 2024

Pull Request

Description

Added Hypridle implementations.

Important

[LOG] Using dbus path /org/freedesktop/login1/session/_32
Seldomly, some apps don't respect and communicate to inhibit idle! This is not Hyprdots fault or Hypridle
Therefore if this happens click  🕛 to inhibit idle

TODO

Should this be an optional package?

Hyprlock

Goals

  1. Reproduce configs with per monitor scaling compatibility or wait for this to be answered [Feature Request ] Follow Scaling per monitor by default hyprwm/hyprlock#261
  2. Widgets should be modular so users can just source or copy it to there preferred config. see ./.config/hyprlock/widgets
  3. Layouts should be a plug in play configuration see ./.config/hyprlock/presets. This way users can share custom layouts.

@rubiin
Copy link
Contributor

rubiin commented Apr 20, 2024

I think this can be merged as well

@rubiin
Copy link
Contributor

rubiin commented Apr 21, 2024

@kRHYME7 I think the merge conflicts are blocking the pr from merge

@kRHYME7
Copy link
Collaborator Author

kRHYME7 commented Apr 21, 2024

Ohhh I totally forgot about this lol!

@kRHYME7 kRHYME7 requested a review from rubiin April 21, 2024 13:23
Copy link
Contributor

@rubiin rubiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kRHYME7 kRHYME7 marked this pull request as draft April 24, 2024 14:07
@kRHYME7 kRHYME7 changed the title Hypridle listeners Hyprlock ++ Hypridle listeners Apr 24, 2024
@kRHYME7
Copy link
Collaborator Author

kRHYME7 commented Apr 24, 2024

Will work on Hyprlock here

@ChrolloRifat
Copy link

ChrolloRifat commented Apr 24, 2024

Will work on Hyprlock here

okay. The current roadblock we are facing with hyprlock is the scaling, right?

@kRHYME7
Copy link
Collaborator Author

kRHYME7 commented Apr 24, 2024

yes because most of the scaling are in font size

@kRHYME7
Copy link
Collaborator Author

kRHYME7 commented Apr 24, 2024

Goals

  1. Reproduce configs with per monitor scaling compatibility or wait for this to be answered [Feature Request ] Follow Scaling per monitor by default hyprwm/hyprlock#261
  2. Widgets should be modular so users can just source or copy it to there preferred config. see ./.config/hyprlock/widgets
  3. Layouts should be a plug in play configuration see ./.config/hyprlock/presets. This way users can share custom layouts.

2 monitors with different scaling

image

@dieBakterie
Copy link
Contributor

When did hyprlock+hypridle gets an option im HyDE to for the User to test?

@kRHYME7
Copy link
Collaborator Author

kRHYME7 commented Apr 29, 2024

You can test it here or contribute to some layouts.

I literally added the goals. Number 1 is not yet accomplished.

@dieBakterie
Copy link
Contributor

Screenshot_2024-05-08-09-34-20-186_com.github.android.jpg

Seems Like Goal 1 is reached? Now to the Feedback Sourcing, like with the monitor configs doesn't really worked for me(got removed for a reason), also don't know why the colors.conf got deleted and how do i exactly use the hyprlock.dcol file? Also could you Change your Script that it's not only for Spotify? I've this weird issue that my Screen locks when executing a Script from HyDE that i guess uses the globalcontrol.sh, the wallpaper Change and wallbash mode keybind for example locks my screen, not sure it's propably my fault. And i've this annoying issues that my second Monitor doesn't really wakeup when hypridle is triggered, i need to turn on and off again and then i've the workspaces 2 and 3 where two my second and three my First one ist that's left from my second one. Don't know if that's even Hypridle's, Hyprlock's, Hyprland's fault or my config that's "wrong". I also have the Problem with the wallpaper only schowing up on one Monitor and the other one is black, it's just the Background for hyprlock Not showing. Also path = screenshot doesn't work for me. I'm on Nvidia and i don't think it's this PR's fault.

@se7en-x230
Copy link

se7en-x230 commented May 8, 2024

I have a bit special setup for my music
basically I use lf as my file browser and added a keybinding to open mpv with

mpv --shuffle --no-video --pause=no

for whatever reason the creation of hypr-mpris.inf works but the extraction to the png only randomly.
The Artist/Title part works fine only the folderart only sometimes.
My collection is sorted and has the corrected tags. All done with MusicBrainz

If I listen on yt it works fine

Any ideas?

@kRHYME7
Copy link
Collaborator Author

kRHYME7 commented May 8, 2024

@se7en-x230 playerctl metadata --format '{{mpris:artUrl}}' this should output the mpris art if it existed.

@se7en-x230
Copy link

@se7en-x230 playerctl metadata --format '{{mpris:artUrl}}' this should output the mpris art if it existed.

It does that part works fine ...

I hacked this together and up to now that works

image

I basically check if the folder has a image (which 99% of them have) and copy it to /tmp/

Not pretty but for now it works

@kRHYME7
Copy link
Collaborator Author

kRHYME7 commented May 8, 2024

Uhm, Can you try the latest commits? I think this script is outdated

@se7en-x230
Copy link

Uhm, Can you try the latest commits? I think this script is outdated

Yes that's too much as there are too many changes in several dotfiles for this to work. I wait for your finished dotfiles

@dieBakterie
Copy link
Contributor

I've problems with this and the newest hyprlock.sh script too.

@kRHYME7
Copy link
Collaborator Author

kRHYME7 commented May 8, 2024

I've problems with this and the newest hyprlock.sh script too.

Some error message or explanation is better

@dieBakterie
Copy link
Contributor

dieBakterie commented May 8, 2024

Line 42 fn_ command not found. Your Script without any changes.

@se7en-x230
Copy link

Also your roman_clock.sh is still called in one or more of the presets

@kRHYME7
Copy link
Collaborator Author

kRHYME7 commented May 8, 2024

Also your roman_clock.sh is still called in one or more of the presets

ops, ok will remove it

@abenezerw
Copy link

abenezerw commented May 15, 2024

IMG_1297

  1. I think if you guys don’t define monitor like eDP-2 blur effect will take on all monitors.
  2. The widgets work, just that the hyprlock.conf only has a few sourced even though the files are there.
  3. The Input field colors work on all themes, they change accordingly
  4. Now its just the wallpaper that doesn't appear. maybe cause its still calling from swww? and i dont see that file anywhere

@kRHYME7
Copy link
Collaborator Author

kRHYME7 commented May 15, 2024

Change wallpapers so it will be updated

@abenezerw
Copy link

Change wallpapers so it will be updated

Oh, yeah. it works but i only see that wallpaper for a blink of a sec before it goes full black on lock. i also manually put a sww folder with backgorund png to check and it also shows it for a sec before black bg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants