Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nvim #1122

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

add nvim #1122

wants to merge 17 commits into from

Conversation

jpx40
Copy link
Contributor

@jpx40 jpx40 commented Mar 19, 2024

Add nvim + possibilty to change color. Color changing is not complete yet, but we can use lazyvim for that, it has one function to change the whole theme. No need for advanced Plugins anymore. I will add an integration to the tools from this repo later.

colorsheme lazyvim

@jpx40
Copy link
Contributor Author

jpx40 commented Mar 19, 2024

i haven't found nvim themes for all used themes of this repo what should i do with the rest.

@@ -66,10 +66,33 @@ firefox # browser
kitty # terminal
dolphin # kde file manager
ark # kde file archiver
vim # terminal text editor
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we dont need it anymore if we have neovim added an alias to novim to launch it with vim

@Enigma1309
Copy link
Contributor

i haven't found nvim themes for all used themes of this repo what should i do with the rest.

go with default or something famous like Catppuccin-mocha or Dracula or Nord

@jpx40
Copy link
Contributor Author

jpx40 commented Mar 19, 2024

i haven't found nvim themes for all used themes of this repo what should i do with the rest.

go with default or something famous like Catppuccin-mocha or Dracula or Nord

ok

@ffoebel
Copy link

ffoebel commented Mar 20, 2024

Always great to have more people experience a properly configured (n)vim, but this should be skipped if neovim is already installed and especially configured.
Don’t mess with a devs config 😅

@jpx40
Copy link
Contributor Author

jpx40 commented Mar 20, 2024

Always great to have more people experience a properly configured (n)vim, but this should be skipped if neovim is already installed and especially configured.
Don’t mess with a devs config 😅

We need a backup to prevent this issue. I will start an discussion to discuss the status of backup. We might need an choice menu in the installer for neovim

Copy link
Collaborator

@kRHYME7 kRHYME7 Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider moving the nvim deps on a separate file. e.g ``` nvim_deps.lst?

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Mar 20, 2024

I have some suggestions regarding this change. I hope my claims are valid (Please correct me )

  • Make this change atomic as possible ( Looks good ✔️)

  • Modular to the extent that users have an option to not overwrite their own config. I happened to watch this video a while ago https://www.youtube.com/watch?v=LkHjJlSgKZY I think we can move our nvim configs somewhere e.g ~/.configs/hyprvim (whatever sounds best) then we can use alias to use the nvim from ./hyprvim . Also I think it would be cool if we adapt the config switching. (So we can't messed with devs configs)

  • Considering having the color scheme per theme, we can modify this, right? http://www.lazyvim.org/plugins/colorscheme.
    Bonus, If this is a template, we can integrate wallbash for this.

  • The configurations are easy to manage, but the deps should be listed on and optional file ( too many package deps). e.g. nvim_dep.lst then we can just merge this into the final install_pkg.lst only if users choose to populate the nvim.

Okay that's my 2 cents.

@jpx40
Copy link
Contributor Author

jpx40 commented Mar 20, 2024

I have some suggestions regarding this change. I hope my claims are valid (Please correct me )

* Make this change atomic as possible (  Looks good ✔️)

* Modular to the extent that users have an option to not overwrite their own config. I  happened to watch this video a while ago https://www.youtube.com/watch?v=LkHjJlSgKZY I think we can move our nvim configs somewhere e.g `~/.configs/hyprvim` (whatever sounds best) then we can use alias to use the nvim  from ./hyprvim . Also I think it would be cool if we adapt the config switching. (So we can't messed with devs configs)

* Considering having the color scheme per theme, we can modify this, right? http://www.lazyvim.org/plugins/colorscheme.
  Bonus, If this is a template, we can integrate wallbash for this.

* The configurations are easy to manage, but the deps should be listed on and optional file ( too many package deps).   e.g. `nvim_dep.lst ` then we can just merge this into the final    `install_pkg.lst`  only if users choose to populate the nvim.

Okay that's my 2 cents.

yeah, lazyvim gives access to color sheme through that function. Advantage over normal neovim is we don't have to configure everything manually. We have to preinstall all colorshemes, but only one is loaded at startup. The Configs of the .config/nvim dir are reloaded every start so all we have to do is changing the colorsheme file.

https://github.com/prasanthrangan/hyprdots/pull/1122/files#diff-45dbda7ff2c87986caf4ee9128940f64aa4864e5bfcc1d01b5c83a2cd059fd18

@jpx40
Copy link
Contributor Author

jpx40 commented Mar 22, 2024

I will work again this weekend on the commit, had no time. Is it ok if I add some ruby code or lua code to automate stuff?

@prasanthrangan
Copy link
Owner

i think we need something like archinstall to record user choice for default apps before install.

@jpx40
Copy link
Contributor Author

jpx40 commented Mar 22, 2024

i think we need something like archinstall to record user choice for default apps before install.

yeah, do you like ruby? i want do learn it. we could the programm in ruby

@prasanthrangan
Copy link
Owner

yeah, do you like ruby? i want do learn it. we could the programm in ruby

I've no idea about ruby so i wont be able to help :(
I was thinking about python (like archinstall) as a wrapper with simple-term-menu

@jpx40
Copy link
Contributor Author

jpx40 commented Mar 22, 2024

yeah, do you like ruby? i want do learn it. we could the programm in ruby

I've no idea about ruby so i wont be able to help :( I was thinking about python (like archinstall) as a wrapper with simple-term-menu

Ruby is simble think python just slightly different syntax

@jpx40
Copy link
Contributor Author

jpx40 commented Mar 22, 2024

yeah, do you like ruby? i want do learn it. we could the programm in ruby

I've no idea about ruby so i wont be able to help :( I was thinking about python (like archinstall) as a wrapper with simple-term-menu

class Numeric
  def plus(x)
    self.+(x)
  end
end

y = 5.plus 6
# y is now equal to 11

you just use end after an function. there still some differnce like the for loop, or the optional ().

# puts is like print in python
puts("hallo")

# is equal to
puts "Hallo"

@ffoebel
Copy link

ffoebel commented Mar 22, 2024

Python is almost guaranteed to be installed on any system, ruby would be a dependency you introduce.

@jpx40
Copy link
Contributor Author

jpx40 commented Mar 22, 2024

Python is almost guaranteed to be installed on any system, ruby would be a dependency you introduce.

yeah that's true, i just don't like pythons syntax

@jpx40
Copy link
Contributor Author

jpx40 commented Mar 23, 2024

yeah, do you like ruby? i want do learn it. we could the programm in ruby

I've no idea about ruby so i wont be able to help :( I was thinking about python (like archinstall) as a wrapper with simple-term-menu

how should the cli look like? should we have an menu where the user could choose what he wants to install? we could make it integrate in the existing installer. we shouldn't bundle the code of the tool with this app.

@jpx40
Copy link
Contributor Author

jpx40 commented Mar 23, 2024

https://github.com/jpx40/hyperdots_installer started doing smth

@prasanthrangan
Copy link
Owner

https://github.com/jpx40/hyperdots_installer started doing smth

Great, thank you so much!

@jpx40
Copy link
Contributor Author

jpx40 commented Mar 24, 2024

https://github.com/jpx40/hyperdots_installer started doing smth

Great, thank you so much!

i chose rust if this ok. I can show you the logic of it if wanna. To use it you need to install Rust. https://www.rust-lang.org/learn/get-started

we could add python bindings

@jpx40
Copy link
Contributor Author

jpx40 commented Mar 24, 2024

https://github.com/jpx40/hyperdots_installer started doing smth

Great, thank you so much!

currently i write every thing to custom_hypr.lst so we could start tho tool right before that step.

@jpx40
Copy link
Contributor Author

jpx40 commented Mar 24, 2024

@prasanthrangan can u add the theme switcher for me? Is there an way to disable it per application basis when not can we at it. Just simple booleans in themeswitch.

@prasanthrangan
Copy link
Owner

prasanthrangan commented Mar 25, 2024

@prasanthrangan can u add the theme switcher for me? Is there an way to disable it per application basis when not can we at it. Just simple booleans in themeswitch.

Sure happy to help... but what's the use of boolean switch per application? any specific reason??

Also, i've got an idea to improve theme switcher framework which can reuse swwwallbash to deploy theme based colors... I'm kinda stuck with work and exams this week, but let me dig into this next week!

@jpx40
Copy link
Contributor Author

jpx40 commented Mar 25, 2024

@prasanthrangan can u add the theme switcher for me? Is there an way to disable it per application basis when not can we at it. Just simple booleans in themeswitch.

Sure happy to help... but what's the use of boolean switch per application? any specific reason??

Also, i've got an idea to improve theme switcher framework which can reuse swwwallbash to deploy theme based colors... I'm kinda stuck with work and exams this week, but let me dig into this next week!

i just like my neovim in Dark mode so i wanna have the option to disabable stuff optionally

@prasanthrangan
Copy link
Owner

prasanthrangan commented Mar 25, 2024

i just like my neovim in Dark mode so i wanna have the option to disabable stuff optionally

hmm oki... the new framework should support it without introducing any new variables or checks!
I've created a dev branch named hyde... i'll try to implement the new themeswitcher next week :)

@jpx40
Copy link
Contributor Author

jpx40 commented Mar 25, 2024

i just like my neovim in Dark mode so i wanna have the option to disabable stuff optionally

hmm oki... the new framework should support it without introducing any new variables or checks!
I've created a dev branch named hyde... i'll try to implement the new themeswitcher next week :)

I already added some code regarding this code is in the pull. I am mobile will sent rught commit later. Another improvement recommendation move code out of .config/hyperdots/script to .local/share/hyprdots. Just keep the most important configs in .config.

https://github.com/jpx40/hyprdots/blob/unschanged/Configs/.config/hyprdots/scripts/themeswitch.sh

@jpx40
Copy link
Contributor Author

jpx40 commented Mar 25, 2024

i just like my neovim in Dark mode so i wanna have the option to disabable stuff optionally

hmm oki... the new framework should support it without introducing any new variables or checks! I've created a dev branch named hyde... i'll try to implement the new themeswitcher next week :)

i wanna try out some new stuff, we might profit from an projekt like toml bombardil or chezmoi. Dotfile manager.

https://oknozor.github.io/toml-bombadil/
https://www.chezmoi.io/

@mahaveergurjar
Copy link
Contributor

Please resolve the branch conflicts so this PR can merge in this repo and also change the pr acc to hyde

@jpx40
Copy link
Contributor Author

jpx40 commented Apr 24, 2024

Please resolve the branch conflicts so this PR can merge in this repo and also change the pr acc to hyde

will do at the weekend when i find time but changed can be hold back.

@rubiin
Copy link
Contributor

rubiin commented Apr 25, 2024

Hyde-cli provides neovim support I guess

@mahaveergurjar
Copy link
Contributor

Yes but only install nvim not config file because the nvim package name in custom app list that why hyde-cli show nvim option but only install nvim not nvim config because the nvim config are not this repo

240425_11h21m41s_screenshot

@mahaveergurjar
Copy link
Contributor

mahaveergurjar commented May 15, 2024

@jpx40 It is possible to nvim theme disable and support kitty terminal theme
only background color

@jpx40
Copy link
Contributor Author

jpx40 commented May 15, 2024

le to nvim theme di

i think there is plugin for that https://github.com/psliwka/termcolors.nvim haven't updaded this for a while on this since i currently make a theme switcher in Rust. you could try this your self.

@mahaveergurjar
Copy link
Contributor

OK, Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants