Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added callbacks for onNext and onPrevious and Alternated by default horizontal timeline #235

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

avianez-onkologikoa
Copy link

@avianez-onkologikoa avianez-onkologikoa commented Mar 3, 2022

Description

Added callbacks for onNext and onPrevious and Alternated by default horizontal timeline

Additional context

It´s been a quick fix to solve a problem for our usage, use it for your need or adapt it :)

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@prabhuignoto prabhuignoto self-requested a review March 8, 2022 04:51
@@ -0,0 +1,6 @@
import React from 'react';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should not be checking in the dist folder. is there a specific reason for adding it

Comment on lines +1 to +56
/// <reference types="react" />
import { Theme } from '../../../models/Theme';
import { TimelineMode } from '../../../models/TimelineModel';
export declare const TimelineNavWrapper: import("@emotion/styled").StyledComponent<{
theme?: import("@emotion/react").Theme | undefined;
as?: import("react").ElementType<any> | undefined;
} & {
theme?: Theme | undefined;
}, import("react").DetailedHTMLProps<import("react").HTMLAttributes<HTMLUListElement>, HTMLUListElement>, {}>;
export declare const TimelineNavItem: import("@emotion/styled").StyledComponent<{
theme?: import("@emotion/react").Theme | undefined;
as?: import("react").ElementType<any> | undefined;
} & {
disable?: boolean | undefined;
}, import("react").DetailedHTMLProps<import("react").LiHTMLAttributes<HTMLLIElement>, HTMLLIElement>, {}>;
export declare const TimelineNavButton: import("@emotion/styled").StyledComponent<{
theme?: import("@emotion/react").Theme | undefined;
as?: import("react").ElementType<any> | undefined;
} & {
mode?: TimelineMode | undefined;
rotate?: "TRUE" | "FALSE" | undefined;
theme?: Theme | undefined;
}, import("react").DetailedHTMLProps<import("react").ButtonHTMLAttributes<HTMLButtonElement>, HTMLButtonElement>, {}>;
export declare const TimelineControlContainer: import("@emotion/styled").StyledComponent<{
theme?: import("@emotion/react").Theme | undefined;
as?: import("react").ElementType<any> | undefined;
} & {
flip?: boolean | undefined;
slideShowActive?: boolean | undefined;
}, import("react").DetailedHTMLProps<import("react").HTMLAttributes<HTMLDivElement>, HTMLDivElement>, {}>;
export declare const ControlButton: import("@emotion/styled").StyledComponent<{
theme?: import("@emotion/react").Theme | undefined;
as?: import("react").ElementType<any> | undefined;
} & {
theme?: Theme | undefined;
}, import("react").DetailedHTMLProps<import("react").ButtonHTMLAttributes<HTMLButtonElement>, HTMLButtonElement>, {}>;
export declare const MediaToggle: import("@emotion/styled").StyledComponent<{
theme?: import("@emotion/react").Theme | undefined;
as?: import("react").ElementType<any> | undefined;
} & {
theme?: Theme | undefined;
} & import("react").ClassAttributes<HTMLButtonElement> & import("react").ButtonHTMLAttributes<HTMLButtonElement> & {
children?: import("react").ReactNode;
} & {
theme?: import("@emotion/react").Theme | undefined;
}, {}, {}>;
export declare const ReplayWrapper: import("@emotion/styled").StyledComponent<{
theme?: import("@emotion/react").Theme | undefined;
as?: import("react").ElementType<any> | undefined;
} & {
theme?: Theme | undefined;
} & import("react").ClassAttributes<HTMLButtonElement> & import("react").ButtonHTMLAttributes<HTMLButtonElement> & {
children?: import("react").ReactNode;
} & {
theme?: import("@emotion/react").Theme | undefined;
}, {}, {}>;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need to check in the dist folder.

@sonarcloud
Copy link

sonarcloud bot commented Apr 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants