Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPF Features functionality #383

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

UPF Features functionality #383

wants to merge 7 commits into from

Conversation

Jibun
Copy link

@Jibun Jibun commented Jul 17, 2017

Hi,

In Pompeu Fabra University, UPF (Barcelona, Spain) we have added a new functionality consisting of a set of features that can be added, accessed and removed from an interval or a point within a tier of a Textgrid.
The functionality is working with the version v6.0.29 of the software.
However, resulting Textgrids are backwards compatible, since our features are encoded over the interval/point label.
We would like out extension to be added to the official release. As we believe it could be useful for other users of the application.
You can read further details of the features functionality in our publication (Domínguez et al., 2016) https://www.aclweb.org/anthology/C/C16/C16-2046.pdf
We are currently using it in our client/server deployment of Praat that we will be releasing soon.

Thank you.

Conflicts:
	fon/Makefile
	fon/TextGrid.h
	fon/TextGridEditor.cpp
	fon/praat_TextGrid_init.cpp
@Jibun Jibun changed the title Upf UPF Features functionality Jul 17, 2017
Char32 pointers replaced for MelderString and autoMelderString widely in
structures and functions
Memory management revised
Duplicated functions deleted
Text treatment functions like trim added as MelderString functions
New processing functions created to clean up interface code
Functions renamed to better fit Praat's notation and names pollution
solved
Conflicts:
	.gitignore
	fon/TextGrid.cpp
	fon/TextGrid.h
@Jibun
Copy link
Author

Jibun commented Nov 15, 2017

Hi Paul,

Following you recomendations we have done changes to our implementation.
Could you please take a look at the code to check if there is anything else to be changed or if you have any further suggestion?

Here there is a list of the changes we have done:

  • Char32 pointers replaced for MelderString and autoMelderString widely in structures and functions
  • Memory management revised
  • Duplicated functions deleted
  • Text treatment functions like trim added as MelderString functions
  • New processing functions created to clean up interface code
  • Functions renamed to better fit Praat's notation and names pollution solved
  • Code merged and adapted to base branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant