Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split recording functionality - part 1 - recording #223

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

READSEARCH
Copy link

@READSEARCH READSEARCH commented Jun 1, 2016

After our previous discussion,
we rewrote the code and took all auto-save out of it. We will make two different fixes.

For now, this first fix only concentrates on the recording of multiple audio files on the easiest possible way. http://postimg.org/image/8z2hf5fjf/ It is turned off by default but when activated, it includes also the numbering system, so it is easy to find files in the Object list later on.

The ‘save all’ functionality will be added later. That code was already written (with all warnings etc), but we have to look where to implement it. That new work will happen after this existing code is in ok.

@READSEARCH
Copy link
Author

Can someone of the team have a review on this, so we know how to continue with part 2 if desired?

@PaulBoersma
Copy link
Member

Can you give a description of what this is supposed to do, differently from clicking Stop -- Save to List -- Record? I think I can sort of interpret your Hungarian notation, but I don't get the functions of the four widgets that you're adding. You talk about "auto-saving" and "files", but you also call the objects in the Object List "files", so I cannot see whether there you foresee any file saving (to disk) in Part 2.

@READSEARCH
Copy link
Author

I currently don't have access to the source code, so to make things clear I made an image with a proposal for a more clear wording: https://postimg.org/image/cki3ennk3/

The difference with Praat as it currently is, is that 3 steps are merged. The split recording button does next steps on its own:

  1. it places the previous recording into the object list
  2. it numbers all objects in the object list so that they have a unique name
  3. it starts a new audio recording (with a unique name).

When recording different utterances (being sounds or sentences) with a quick succession (less then 2 secs between the utterances), there is no time to use the buttons of Praat. The 'split recording' made sure that there are different recordings for each utterance.

In our earlier pull request, #209, you asked us to first do the 'split recording' functionality and, in a separate patch, to add a new button to save all items in the object list in the computer. We are still willing to do that second patch when the current implementation is ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants