Fix --pref-dir option that is broken since v6.2.05 #2097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The preferences folder setup was being done before parsing the program arguments, so before parsing the --pref-dir option.
jeojr
changed the title
jeojr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The preferences folder setup was being done before parsing the program
arguments, so before parsing the --pref-dir option.
I'm moving only the code block that does the preferences folder configuration to right after the while loop that does the argv parsing.
To be more specific, the commit 0b67f1d is what broke --pref-dir. In sys/praat.cpp, a code block (lines 1470 to 1556 in the previous commit - a3574e3) was moved to before the argv parsing.
P.S. Before the "argv while loop" there is a
forto trace argv. I think it needs to come after too, after parsing the --trace option.