Update BASS libraries and add BASSLoud #6233
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
smallketchup82
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite for ppy/osu#27793
Would be wise to wait for peppy/ManagedBass#1 to get merged before reviewing this
This PR updates the BASS libraries to their latest version and also adds BASSLoud. In my testing using this, there does not seem to be any breaking changes or incompatibility.
Current Version: 2.4.16
New Version: 2.4.17
Relevant docs:
The only issue I've found with this is that osu! might not open on arm windows due to bassloud not being found, as there's no arm version for bassloud. As usual, you'll have to make a new version of
ppy.Framework.NativeLibsupon merging