Fix dropdown/menu components not providing items in correct order #6079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenzibyte
commented
Dec 13, 2023
| @@ -62,7 +62,7 @@ public abstract partial class Menu : CompositeDrawable, IStateful<MenuState> | |||
| /// <summary> | |||
| /// Gets the item representations contained by this <see cref="Menu"/>. | |||
| /// </summary> | |||
| protected internal IReadOnlyList<DrawableMenuItem> Children => itemsFlow.Children; | |||
| protected internal IEnumerable<DrawableMenuItem> Children => itemsFlow.Children.OrderBy(c => itemsFlow.GetLayoutPosition(c)); | |||
There was a problem hiding this comment.
In case anyone asks, we cannot use FlowingChildren here as it filters the items by extra properties that are not wanted (life state).
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in
Dropdownis quite ugly, I would rather let the component always store a bindable list and get away with the extra list storage, but I'm not fully confident about pushing such change any time soon.