New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Test improvements #2131
base: develop
Are you sure you want to change the base?
[WIP] Test improvements #2131
Conversation
It's safe to assume that after 6 years everyone is on psutil version > 2.0.0
…ing of username before)
…ed for test classes that should get tested directly
…ok at the performance. This is to test on machines with high load, especially GitHub Actions
…seconds before/afterwards
…C (this is the behaviour that was default before Python 3.8)
… daemon env is different for each environment, this has to be defined in conftest at module level Dependency Injection at its best, I'm really proud of this commit
…supported for all bindings
…ts that actually a daemon
Some questions about the shell tests: Fish is also not passing, but this was not included for Travis CI tests before, so maybe something is diverging there. Can I just drop that one from the tests? |
I guess for now it would be OK to drop these tests; perhaps we should look into them again later, though. |
its a fake code sorry 8cee18d |
Hi, We are trying to stop using Thanks a lot for your work! |
Oh well, it's been a long time since I worked on it. It's not really high on my radar right now and I don't really use Powerline itself anymore, but am rather going for alternatives. Could take a look how the state is right now if I find time for that |
This is a WIP Pull request which directly addresses #2128
Let me elaborate the idea that I have for the testing environment and the changes that I have done:
Please let me know if you have some general concerns about the style of this test suite. If this is not the case, I'll continue rewriting the missing tests.
PS: I'd appreciate getting a
hacktoberfest-accepted
label for this PR once it is feature-complete