Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace awesome-client with a Python-native dbus interface. #1771

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

brycied00d
Copy link

Instead of spawning awesome-client every couple of seconds to update the
widget, use Python's own native dbus interface. Fewer system resources used by
avoiding the spawn as well as removing noise on the dbus caused by open+close.

I haven't updated the tests for this as I'm unsure just how to test. The current tests
replace awesome-client with its own version that logs the request but doesn't
connect to awesome. Problem is that by removing that layer(s), I haven't a clue
how to "intercept" or shim the dbus interface. I'm happy to take suggestions.

Instead of spawning awesome-client every couple of seconds to update the
widget, use Python's own native dbus interface. Fewer system resources used by
avoiding the spawn as well as removing noise on the dbus caused by open+close.

Signed-off-by: Bryce Chidester <bryce@cobryce.com>
@ZyX-I
Copy link
Contributor

ZyX-I commented May 13, 2017

I guess you will have to remove tests/test_awesome and use tests/test_python with dbus module mocks (search for replace_module_module in tests/test_python/test_….py files). Though if you have some other idea which includes running tests with awesome and dependencies being installed, but not running (so far there are no such tests for WM bindings because I had no such ideas) then you are also welcome.

@brycied00d
Copy link
Author

Thanks for the tip, @ZyX-I I'll get to work on implementing that, fixing the CI failure and re-adding awesome-client as a fallback when python-dbus isn't installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants