Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add randomString() to AuthUtils #1141

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

raghavbhatia336
Copy link

@raghavbhatia336 raghavbhatia336 commented Mar 26, 2021

A small pending task to add duplicate function randomString() to util.js and use it in digest.js and hawk.js.
Todo comment

@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #1141 (3acc2d3) into develop (daf1da0) will increase coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1141      +/-   ##
===========================================
+ Coverage    90.98%   91.19%   +0.21%     
===========================================
  Files           42       43       +1     
  Lines         2573     2568       -5     
  Branches       741      740       -1     
===========================================
+ Hits          2341     2342       +1     
+ Misses         232      226       -6     
Flag Coverage Δ
integration 79.75% <100.00%> (+0.19%) ⬆️
legacy 56.15% <93.33%> (+0.14%) ⬆️
unit 49.29% <46.66%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/authorizer/digest.js 89.89% <100.00%> (-0.37%) ⬇️
lib/authorizer/hawk.js 73.52% <100.00%> (+5.10%) ⬆️
lib/authorizer/util.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daf1da0...3acc2d3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant