Add Support for OCI Authentication Protocol #1109
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1109 +/- ##
===========================================
- Coverage 91.10% 89.97% -1.14%
===========================================
Files 42 44 +2
Lines 2563 2712 +149
Branches 735 758 +23
===========================================
+ Hits 2335 2440 +105
- Misses 228 272 +44
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
codenirvana
requested changes
Jan 7, 2021
Comment on lines
+56
to
+57
| "http-signature": "1.3.1", | ||
| "sshpk": "1.16.1" |
There was a problem hiding this comment.
Can we place these in the right order?
| * Specification document: https://docs.cloud.oracle.com/en-us/iaas/Content/API/Concepts/signingrequests.htm | ||
| */ | ||
| var sshpk = require('sshpk'), | ||
| UrlParser = require('url'), |
There was a problem hiding this comment.
Use postman-url-encoder instead
| urlEncoder = require('postman-url-encoder'), | ||
| RequestBody = require('postman-collection').RequestBody, | ||
| bodyBuilder = require('../requester/core-body-builder'); | ||
|
|
| // ------------------------------------------------------------ | ||
|
|
||
| // eslint-disable-next-line one-var | ||
| var convertToDomHeadersObject = function (postmanHeaders) { |
There was a problem hiding this comment.
Why do we have to convert PostmanHeaderList?
Facing any issue with the get/set methods exposed by it?
| "tenancy": "ocid1.tenancy.oc1..aaaaaaaa5h4h55rwzjwrufcfaqp4h5gxcqv65ozk7rytrvcltwujfj45g25a", | ||
| "user": "ocid1.user.oc1..aaaaaaaax4esyzwnhlxdb6h5dfopzkuw5kujtffz3y4yvczqnjwlpbnk7q7q", | ||
| "fingerprint": "42:34:8b:df:0a:9c:b0:c8:b6:ac:7a:c2:ce:7e:45:85", | ||
| "privatekey": "-----BEGIN RSA PRIVATE KEY-----\nMIIEpAIBAAKCAQEAvOxs9ybstMcalgCEbNIHeNh7oqVBLAC0+bhi7KEr2xYFSQws\nu4MdPXqSCTQu1/4fsMoCbRLZMRmC8YonjjhdRyVFZrAkE5Q9WfF3N40s/GVK8Myb\nWxBS5hZnc4td/d+OoGLE5aKNwaFNoTn7iDCU1JfG+d4l7Z5twzHESs3XnzNSeRms\n/MAFk3zdjlpOm9pbafFqFoim6Be8dRXtWU0xN5VRHD3txisQJlcLVNMm6IK9UWUg\nJzmn8d5ASwvU75/nJKc8DLoQ0cVeYaIhXWGME6ApXyb62zKmccPpkRzRZSJYPeUo\nLK2JC/w/os1NAi0mTGb/KqOzd7BJf1RO0SQYHwIDAQABAoIBAGRS4KJ2hyiQuquB\nZtEqz1D7FNyQCQXG8lPR+KZUCCf1j6T01CRXQgXNuxMsJNwKVOXawGMPqUqLk5+U\nj+DUSaRoRGx9iQrko5fJxFc5nvQBDkTFQpKfHoaUyybukWEpgGHnUUvogIKcl87Q\nLaRqt/4VA1LZByciBIOtP+HBYYlmGlg6UDeOFTku9nFbraz8FlzqLAy7xSUB3aDs\n1JeDwR9PBQsRG72GQkJR/EmPbD2Y/r+zmZP25/97pouO/ji9DJwDcVc1qFpn4JKf\nLABBUEwfWEIWa4cefbDi0dCzVKxrS/RU9EYB6HtMklcy3qyxbdcLmFY8qgsxjG8K\nw2iD2iECgYEA+AtmXff5lnSZq3CJhcxBpi+MuCByWH7gB2/G50XSduRmW+lzI6iv\n+r8ADEI87+KBIju++qNvj886N9H1sm+k6j3nEE51i2nwwKB79Xzu0J23+XMSCV0D\nYb6bvNogGCOhKslQNC51ZvgsZlTu6F8/EkPlboEL8E2h4eYwx3L6UbcCgYEAwvub\nB+rhUk4+TwXVnfNZEcmQiz90yU7CI/TjDrHVq+ZJIKRHILB+7Mt7Mpi+7Ie2Cx/f\nA1Alv8I44wmLhZX63Du9hwoz3t4Y0+AiT/RMp3EkmxKIkPFZNKsmY659dNzROMG9\nEVYEmBYode17mrSc4UJi8I4iHCv1A83BC3DhzNkCgYBSE8Od2I5YQOEQn76B7aLT\nkOxpiSMNMX6EN3KD2NDZ0p4kT81vwUPqHwWvCMQNRNAiOc7qNOaXmaTUD7/TeaoC\ncNViyfOPXFD0DKa4Bs0nbukPvAn92y9hSqdSCIOSOUf9VnwZqD3lAr3+ZqBfeBTw\nwFLNDBqdO7MTgw4lEWDPZQKBgQCIm3c2yN0sqR0GiHPtwfz5dVsL9F2CXOewAXbD\naNznHuTFNdOPl5iVlsqt3E6HsV1d1eqNi62m+BCbIKjb4wRrIH/dCMzmrHyAlVv0\n4JiEB8U50HZV9oIlYHP5Ctti8QK03Sf16Wo2k++tD8G11izDtZtUJoDHdBSpoZJK\nzb+loQKBgQC0/VewDbcRW5FymBPJiEnrTtpHk40x14pNfRbRrNDIx/jIx/gnqwyI\n6ud7uJkK+LAHw+r2HjHtSMVE9I54zr+QG8fAe8alJQ3mSP1tlpLbMaMb7LpomKo/\nfVVz1laGP3tcpXDEp80hbrDxO7aOexUgCFKHrYTAgVCm8Eqzz8HdsQ==\n-----END RSA PRIVATE KEY-----" |
There was a problem hiding this comment.
How are we planning to accept this in UI?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.