New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added powershell here strings to powershell-restmethod codegen #395
base: develop
Are you sure you want to change the base?
Added powershell here strings to powershell-restmethod codegen #395
Conversation
Removed a comment at line 14
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@karmanya007 Can you add a sample output snippet with the new changes?
Also could you add/update unit tests?
…7/postman-code-generators into powershellHereStrings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@umeshp7 Changes added.
@umeshp7 All checks have passed and I have added the sample outputs. |
@karmanya007 I have enabled newman tests for poweshell codegen. These tests run the generated snippet in powershell and compare the output with that generated by newman. You can see in the CI logs that some of the tests are failing due to incorrect escaping of characters in the string. We have to get those tests to pass before we can merge your changes. |
@webholik On it! |
@karmanya007 Any updates here? Looks like there are some conflicts. |
@umeshp7 Had a marriage in my family so I was not active as much. I know the fix. Just have to implement it. Will do so shortly. |
…e of sanitization
…e of sanitization
Getting these three errors. @Toronto00 , @umeshp7 Could you guide me in the correct direction on how to approach these conflicts. |
@webholik Are the 1st and 3rd error from wrong newman tests, maybe? |
@karmanya007 1st error is because you are not escaping 2nd error again is just wrong escaping. 3rd has been fixed in #421. You should rebase your PR on top of it. |
@karmanya007 We recently pushed changes to use here-strings in Powershell. Could you check if this PR would still be required? |
Fixes #322 .
Got rid of the escapes by using a PowerShell here-strings in powershell-restmethod codegen.
Request 1
Conversion
Request 2
Conversion