Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Secrets with Kubernetes API #204

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

versilis
Copy link
Contributor

@versilis versilis commented Mar 21, 2023

This addresses a code review suggestion to use the Kubernetes API for generation of secret files when using akita kube secret.

Unfortunately, Kubernetes' current Go API contains an ObjectMeta model that is in misalignment with Kubernetes' open api spec. As a workaround, I've added logic to manually fix the incorrect field (CreationTimestamp) after serialization.

@versilis versilis changed the base branch from main to versilis/kube-secret March 21, 2023 15:46
@versilis versilis force-pushed the versilis/kube-secret-with-api branch 2 times, most recently from 83aaf74 to 64f0125 Compare March 21, 2023 15:53
@versilis versilis requested a review from mgritter March 21, 2023 15:54
@versilis versilis marked this pull request as ready for review March 21, 2023 16:12
@versilis versilis force-pushed the versilis/kube-secret-with-api branch from 64f0125 to 3d5e896 Compare March 21, 2023 16:23
@versilis versilis marked this pull request as draft March 21, 2023 23:22
Base automatically changed from versilis/kube-secret to versilis/kube March 21, 2023 23:52
Base automatically changed from versilis/kube to main March 27, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant