Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of util.inherits() is discouraged. #2908

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

k-rajat19
Copy link

util.inherits() is deprecated and should be avoided to use.
see https://nodejs.org/api/util.html#utilinheritsconstructor-superconstructor

shamasis
shamasis previously approved these changes Jan 21, 2022
@k-rajat19
Copy link
Author

Hi @shamasis , I think codecov status is stuck should i try adding new commits to trigger codecov report again ?
peoples are also facing similar issue -
https://community.codecov.com/t/codecov-status-stuck-at-waiting-for-status-to-be-reported-on-github/341/10

@codecov
Copy link

codecov bot commented Jan 22, 2022

Codecov Report

Merging #2908 (129c893) into develop (a5018ec) will increase coverage by 0.07%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #2908      +/-   ##
===========================================
+ Coverage    90.96%   91.03%   +0.07%     
===========================================
  Files           21       21              
  Lines         1151     1149       -2     
  Branches       349      349              
===========================================
- Hits          1047     1046       -1     
+ Misses         104      103       -1     
Flag Coverage Δ
cli 82.24% <0.00%> (+0.05%) ⬆️
integration 40.99% <0.00%> (-0.02%) ⬇️
library 58.57% <0.00%> (+0.01%) ⬆️
unit 75.10% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/run/secure-fs.js 79.72% <0.00%> (+0.78%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@RaisinTen
Copy link
Member

util.inherits() is deprecated and should be avoided to use.

It's not deprecated, just legacy which means that it's okay if you use it. You can see the differences in https://nodejs.org/api/documentation.html#stability-index. The reason why it's marked legacy is that it doesn't establish the prototype chain as described in nodejs/node#4179 but it works pretty well in most cases. Is this patch aiming to solve a problem we are facing with the usage of util.inherits here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants