Allow overriding the default CORS headers #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Even though this fixes my use case, by running
I know how to fix it, but I'm not sure if it's worthwhile to do it. The last commit on master dates back to 2018. How maintained is this project? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the
Access-Control-*response headers are very permissive. For testing this is nice, but I came across the use case to test with more restrictive headers.I tried to do
GET /response-headers?Access-Control-Allow-Origin=http://example.com, but it replied withAccess-Control-Allow-Origin: *. After this PR these headers can be overridden.