Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support embeds #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support embeds #47

wants to merge 1 commit into from

Conversation

johnholdun
Copy link
Contributor

Adds UI to each story that exposes an embed code, as well as a new render mode that alters the UI a bit when the story is embedded.

Closes #46

@ginatrapani
Copy link
Member

This is very cool!

  • 1 question: How can we make it so the whole embedded story appears, and it doesn't scroll inside the embedded area?
  • 1 feature request: Can the embed code have the option to not show the title of the story at the top? We don't have to add UI for this, it can just be a title=true/false param on the embed src.
  • 1 other question: Thinking about the Insights piece to show this off, I want to make sure: it's possible to embed multiple accounts on 1 page, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable account story embedding
2 participants
@johnholdun @ginatrapani