Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable account story embedding #46

Open
scottwittrock opened this issue Oct 26, 2022 · 1 comment · May be fixed by #47
Open

Enable account story embedding #46

scottwittrock opened this issue Oct 26, 2022 · 1 comment · May be fixed by #47
Assignees

Comments

@scottwittrock
Copy link

Enable the ability to embed an account story like you can with TinySheets.

We could do an insight article like this.

@johnholdun
Copy link
Contributor

Some thoughts for whoever picks this up:

  1. The simplest way to do this is to just give the user an iframe that points to the current URL.
  2. To make the experience a little nicer, we probably want to create an embed mode that hides the menu and maybe changes the padding. This is probably best done with an extra query parameter (i.e. embed=true) that we add into the URL that's part of the iframe code
  3. The final step is adding a "Share" or "Embed" link that lives beside the "View source" link and reveals the embed code right below it. The treatment for this can be identical to how the "View source" link reveals the source code.

@mtashley mtashley removed their assignment Nov 14, 2022
@johnholdun johnholdun linked a pull request Nov 14, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants