Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary onCommand events from package.json #36

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gadenbuie
Copy link
Collaborator

Fixes #35 by removing onCommand:* from activationEvents.

@jcheng5
Copy link
Collaborator

jcheng5 commented Apr 22, 2024

Keep in mind we also target Posit Workbench which might be significantly behind, especially in terms of what customer deployments are actually running.

@gadenbuie
Copy link
Collaborator Author

@jcheng5 that makes sense, I'll check internally for guidance from the Workbench team.

@gadenbuie
Copy link
Collaborator Author

gadenbuie commented Apr 23, 2024

The version of code bundled in Posit Workbench can be found by searching for code version 1. in the Workbench NEWS file. Workbench versions are supported until specific dates, listed on the Posit Support page.

Workbench VS Code Supported until
2022.12 1.71.2 June 30, 2024
2023.03 1.73.1 September 30, 2024
2023.06 1.73.1 December 31, 2024
2023.09 1.79.2 March 31, 2025
2023.12 1.79.2 June 30, 2025

So I'm moving this PR back into draft mode and we can revisit in January 2025.

@gadenbuie gadenbuie marked this pull request as draft April 23, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unnecessary onCommand events from package.json
2 participants