Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP wiring up new content search API #55

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

nealrichardson
Copy link
Collaborator

@nealrichardson nealrichardson commented Feb 27, 2024

No description provided.

Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
548 511 93% 80% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/posit/connect/content.py 97% 🟢
src/posit/connect/paginator.py 100% 🟢
TOTAL 98% 🟢

updated for commit: 08a101f by action🐍

@Lytol
Copy link

Lytol commented Feb 27, 2024

PR is ready for adding the total to the content search results. Also, one observation on the draft PR, you can use the include=owner param to return the user object for the owner with each content item. This is super useful for avoiding n+1 scenarios and is probably worth supporting.

@nealrichardson
Copy link
Collaborator Author

PR is ready for adding the total to the content search results. Also, one observation on the draft PR, you can use the include=owner param to return the user object for the owner with each content item. This is super useful for avoiding n+1 scenarios and is probably worth supporting.

I don't quite follow but please push whatever you think useful to the branch. I'll otherwise wait until your PR lands and gets to radixu, sadly I don't have time to set up a local Connect environment.

Copy link

github-actions bot commented Mar 7, 2024

Hey there! 👋

We noticed that the title of your pull request doesn't follow the Conventional Commits specification. To ensure consistency, we kindly ask you to adjust the title accordingly.

Here are the details:

No release type found in pull request title "WIP wiring up new content search API". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - build
 - chore
 - ci
 - docs
 - feat
 - fix
 - perf
 - style
 - test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants