fix(doclinks): fix help link paths [EE-6861] (#11417)

portainer · Mar 18, 2024 · 6a3eda4 · 6a3eda4
1 parent 889c36f
commit 6a3eda4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/app/react/components/HelpLink/HelpLink.tsx b/app/react/components/HelpLink/HelpLink.tsx
@@ -1,9 +1,11 @@
+import { ReactNode } from 'react';
+
 import { useDocsUrl } from '../PageHeader/ContextHelp/ContextHelp';
 
 type HelpLinkProps = {
-  docLink?: string;
+  docLink: string;
   target?: string;
-  children?: React.ReactNode;
+  children?: ReactNode;
 };
 
 export function HelpLink({
@@ -14,7 +16,7 @@ export function HelpLink({
   const docsUrl = useDocsUrl(docLink);
 
   return (
-    <a href={docsUrl} target={target} rel="noreferrer">
+    <a href={docsUrl} target={target} rel="noopener noreferrer">
       {children}
     </a>
   );

diff --git a/app/react/docker/containers/CreateView/CreateView.tsx b/app/react/docker/containers/CreateView/CreateView.tsx
@@ -17,7 +17,7 @@ import { confirmDestructive } from '@@/modals/confirm';
 import { buildConfirmButton } from '@@/modals/utils';
 import { InformationPanel } from '@@/InformationPanel';
 import { TextTip } from '@@/Tip/TextTip';
-import { useDocsUrl } from '@@/PageHeader/ContextHelp/ContextHelp';
+import { HelpLink } from '@@/HelpLink';
 
 import { useContainers } from '../queries/containers';
 import { useSystemLimits } from '../../proxy/queries/useInfo';
@@ -78,8 +78,6 @@ function CreateForm() {
     isDockerhubRateLimited,
   });
 
-  const createContDocUrl = useDocsUrl('/docker/containers/create');
-
   if (!envQuery.data || !initialValuesQuery) {
     return null;
   }
@@ -103,10 +101,10 @@ function CreateForm() {
           <TextTip>
             The new container may fail to start if the image is changed, and
             settings from the previous container aren&apos;t compatible. Common
-            causes include entrypoint, cmd or
-            <a href={createContDocUrl} target="_blank" rel="noreferrer">
+            causes include entrypoint, cmd or{' '}
+            <HelpLink docLink="/user/docker/containers/advanced">
               other settings
-            </a>{' '}
+            </HelpLink>{' '}
             set by an image.
           </TextTip>
         </InformationPanel>