Add runtime flag to allow disabling config hot-reload (#5079) #5112
+182
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also implemented an alternative solution to this issue here: d75e1ca |
kenjenkins
approved these changes
May 17, 2024
config/config_source.go
Outdated
| if cfg.Options.IsRuntimeFlagSet(RuntimeFlagConfigHotReload) { | ||
| src.watcher.Watch(ctx, []string{configFile}) | ||
| } else { | ||
| log.Warn(ctx).Msg("hot reload disabled") |
There was a problem hiding this comment.
I think we say not to log at warning level (see https://www.pomerium.com/docs/community/contributing#logging) — although I'm sure we're not 100% consistent about this. Still, maybe log at Info() here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds the runtime flag
config_hot_reload(default true) that allows enabling or disabling the hot-reload mechanism for the config file and any other files referenced within it.Related issues
#5079
User Explanation
Checklist
improvement/bug/ etc)