Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow basic-auth for programmatic access #3720

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Seros
Copy link

@Seros Seros commented Nov 1, 2022

Summary

Allow basic-auth for a more feasible way to authenticate for a wide range of web apps

Related issues

Fixes #3687

User Explanation

Check if basic-auth headers are available and if so use them to authenticate your app in a programmatic way, using pomerium as default user name and the JWT as password.

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@Seros Seros requested a review from a team as a code owner November 1, 2022 17:57
@CLAassistant
Copy link

CLAassistant commented Nov 1, 2022

CLA assistant check
All committers have signed the CLA.

@calebdoxsey
Copy link
Contributor

The challenge with this is that other applications may be expecting to use Basic Auth for themselves and we'd be intercepting it. So this is a potentially breaking change.

For the Authorization header we had Authorization: Pomerium and Authorization: Bearer Pomerium- to help prevent that from happening. Is there a way we could do something similar for Basic Auth?

@Seros
Copy link
Author

Seros commented Nov 2, 2022

Thanks for you comment! I see your point about the interception but I think this has already been worked around. As this checks for the specific username pomerium it should only interfere in such cases which probably are edge cases if people configure their apps to use the same name. So in most cases the apps should not have problems using their configured basic auth IMO. In case you don't agree we have to investigate for a different solution which then will probably not as portable as allowing basic auth.

@coveralls
Copy link

coveralls commented Nov 2, 2022

Coverage Status

Coverage increased (+0.05%) to 66.394% when pulling 6a75cfa on Seros:allow-basic-auth into bb5c80b on pomerium:main.

@Seros
Copy link
Author

Seros commented Nov 23, 2022

Hey,
just wanted to ask if there is anything else you need from my side or if we can continue with this PR being merged?

@desimone desimone self-requested a review November 23, 2022 16:24
@calebdoxsey calebdoxsey removed their request for review September 7, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Basic Auth to be used for programmatic access
4 participants