CHOLMOD Wrapper Integration #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zfergus
reviewed
Mar 10, 2022
src/CHOLMODSolver.cpp
Outdated
| b = eigen2cholmod(rhs); | ||
| x = cholmod_l_solve (CHOLMOD_A, L, &b, cm); | ||
|
|
||
| memcpy(result.data(), x->x, result.size() * sizeof(result[0])); |
There was a problem hiding this comment.
might need to resize result before this
src/CHOLMODSolver.hpp
Outdated
| // Base(const Base &) = delete; \ | ||
| // Base &operator=(const Base &) = delete; | ||
|
|
||
| //////////////////////////////////////////////////////////////////////////////// |
|
nice! we need also the ifdefs on top if chlmod is not available |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the initial CHOLMOD wrapper. It might be lacking some additional capabilities like "getinfo".
Currently, the issue is that the code couldn't use GPU. I guess it is because of the version of SuiteSparse being used in polysolve. Could you make the necessary changes in the cmake such that it uses v5.10.1 found here https://github.com/DrTimothyAldenDavis/SuiteSparse/releases
Also, the current code assumes that the input stiffness matrix has inner index type of "long int" instead of "int". This is required because only the long integer version of CHOLMOD can leverage GPU acceleration. Might need to automate it.