Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove POLYFEM_WITH_REMESHING CMake Option #253

Merged
merged 15 commits into from
May 29, 2024
Merged

Remove POLYFEM_WITH_REMESHING CMake Option #253

merged 15 commits into from
May 29, 2024

Conversation

zfergus
Copy link
Member

@zfergus zfergus commented Sep 19, 2023

Make remeshing solely a runtime option.

(also update libigl)

CMakeLists.txt Outdated Show resolved Hide resolved
@teseoch teseoch added the bug Something isn't working label Nov 22, 2023
@zfergus zfergus changed the base branch from main to fix-remesh December 28, 2023 22:40
@zfergus
Copy link
Member Author

zfergus commented Dec 28, 2023

Windows CMake fails with this error:

CMake Error at C:/Program Files/CMake/share/cmake-3.27/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find Filesystem (missing: _found)
Call Stack (most recent call first):
  C:/Program Files/CMake/share/cmake-3.27/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
  C:/Users/runneradmin/.cache/CPM/h5pp/9a95839ec50c29d5555bd20b5f1e69a49e850a6f/cmake/modules/FindFilesystem.cmake:251 (find_package_handle_standard_args)
  C:/Users/runneradmin/.cache/CPM/h5pp/9a95839ec50c29d5555bd20b5f1e69a49e850a6f/cmake/SetupDependencies.cmake:11 (find_package)
  C:/Users/runneradmin/.cache/CPM/h5pp/9a95839ec50c29d5555bd20b5f1e69a49e850a6f/CMakeLists.txt:82 (include)

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 65.37%. Comparing base (609149f) to head (e2b5b39).
Report is 34 commits behind head on main.

Current head e2b5b39 differs from pull request most recent head acb87ae

Please upload reports for the commit acb87ae to get more accurate results.

Files Patch % Lines
src/polyfem/utils/RefElementSampler.cpp 0.00% 2 Missing ⚠️
src/polyfem/quadrature/PolygonQuadrature.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
+ Coverage   64.13%   65.37%   +1.23%     
==========================================
  Files         281      262      -19     
  Lines       34301    32279    -2022     
==========================================
- Hits        21999    21102     -897     
+ Misses      12302    11177    -1125     
Flag Coverage Δ
polyfem 65.37% <25.00%> (+1.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from fix-remesh to main December 29, 2023 04:04
@zfergus zfergus removed the bug Something isn't working label May 29, 2024
@zfergus zfergus self-assigned this May 29, 2024
@zfergus zfergus merged commit aaa4c82 into main May 29, 2024
8 checks passed
@zfergus zfergus deleted the remeshing branch May 29, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants