Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to support Swift 5.0 with Xcode 10.2.1 #11

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

fitsyu
Copy link

@fitsyu fitsyu commented Jun 20, 2019

Hi!

Awesome project!
However the moment I found it, it was available in older swift version.

So here is the updated version of the project for who uses (the current) swift 5.0 and Xcode 10.2.1.

Thanks!

@polok
Copy link
Owner

polok commented Jun 26, 2019

Hi @fitsyu
Many thanks for your PR. I was going to update this library next month, so your work will be helpful!.
I will keep this ticket open till then.

Regards,

@fitsyu
Copy link
Author

fitsyu commented Jun 27, 2019

Hi @fitsyu
Many thanks for your PR. I was going to update this library next month, so your work will be helpful!.
I will keep this ticket open till then.

Regards,

Glad if it can be of help for this project.

I found a strange issue and monkey-patch it in the last commit.

So the last commit probably better just to drop it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants