Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(messagelist): change row size #869

Closed
wants to merge 1 commit into from

Conversation

henryk1229
Copy link
Contributor

Description

Per this ticket, the rows per page option on message review isn't working. This PR uses injectTapEventPlugin to trigger the onRowSizeChange prop on the DataTables component.

Motivation and Context

The functionality was already there to handle row size changes, but the DataTables component isn't registering it. It seems like a known issue, and I found this solution in the linked issue.

How Has This Been Tested?

This has been tested locally.

Screenshots (if appropriate):

Types of changes

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Documentation Changes

Checklist:

  • [x ] My code follows the code style of this project.
  • [x ] My commit messages follow the Conventional Commits specification.
  • My change requires a change to the documentation.
  • I have included updates for the documentation accordingly.

@bchrobot
Copy link
Member

The tap event plugin library has been deprecated and was removed from Spoke in #815. I want to check there is a better fix before reinstating it. Maybe an update to the data tables library?

@henryk1229
Copy link
Contributor Author

Sounds good, I'll take a look

@bchrobot
Copy link
Member

It looks like the library just uses a regular material-ui DropDownMenu under the hood which we use elsewhere in the app without problems 🤔

@henryk1229
Copy link
Contributor Author

Addressed in #876

@henryk1229 henryk1229 closed this Jan 27, 2021
@bchrobot bchrobot deleted the fix/message-list-row-size branch May 9, 2021 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants