Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add holes attribute to polygon #114

Merged
merged 7 commits into from
May 21, 2024
Merged

Add holes attribute to polygon #114

merged 7 commits into from
May 21, 2024

Conversation

Stoops-ML
Copy link
Collaborator

  • Add holes attribute to polygon
  • Add PositionListOfLists property
  • Test added for above changes

@Stoops-ML
Copy link
Collaborator Author

@astrojuanlu any idea why the circleci quality check is failing?

@astrojuanlu
Copy link
Member

Ugh, direct invokations of setup.py on the command line are deprecated and possibly broken...

python setup.py check

Looks like we'll need to get the CI green first (worth doing so in a separate PR)

@Stoops-ML Stoops-ML marked this pull request as draft May 9, 2024 05:44
@codecov-commenter
Copy link

codecov-commenter commented May 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.23%. Comparing base (0477d4a) to head (97a024b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #114   +/-   ##
=======================================
  Coverage   99.22%   99.23%           
=======================================
  Files          12       12           
  Lines         776      784    +8     
=======================================
+ Hits          770      778    +8     
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Stoops-ML Stoops-ML marked this pull request as ready for review May 12, 2024 13:48
@Stoops-ML
Copy link
Collaborator Author

This would close #96

astrojuanlu
astrojuanlu previously approved these changes May 21, 2024
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@astrojuanlu
Copy link
Member

Will require editing some merge conflicts

@astrojuanlu astrojuanlu merged commit 7f24f78 into poliastro:main May 21, 2024
5 checks passed
@Stoops-ML Stoops-ML deleted the holes branch May 21, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants