-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add holes attribute to polygon #114
Conversation
Stoops-ML
commented
May 7, 2024
- Add holes attribute to polygon
- Add PositionListOfLists property
- Test added for above changes
@astrojuanlu any idea why the circleci quality check is failing? |
Ugh, direct invokations of
Looks like we'll need to get the CI green first (worth doing so in a separate PR) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
=======================================
Coverage 99.22% 99.23%
=======================================
Files 12 12
Lines 776 784 +8
=======================================
+ Hits 770 778 +8
Misses 6 6 ☔ View full report in Codecov by Sentry. |
This would close #96 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Will require editing some merge conflicts |