Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

修改数据库连接地址缺少参数 #113

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

修改数据库连接地址缺少参数 #113

wants to merge 3 commits into from

Conversation

hadoop835
Copy link

lQLPJwZok4Z2HDzM780GprBjWYbuGn5cSwOJ9jG0gIwA_1702_239

@CLAassistant
Copy link

CLAassistant commented Dec 7, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

ZSYTY
ZSYTY approved these changes Dec 8, 2022
View reviewed changes
Copy link
Collaborator

@ZSYTY ZSYTY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joeCarf
Copy link
Contributor

joeCarf commented Dec 8, 2022

LGTM

Honestly I don't think this change is necessary, could you plz explain why these default setting should be written explicitly?

@hadoop835
Copy link
Author

@joeCarf Do you have a good solution to this problem？？？

@joeCarf
Copy link
Contributor

joeCarf commented Dec 9, 2022

@joeCarf Do you have a good solution to this problem？？？

Which approach are you using, are you debugging cn in your IDE or compile source code ?
I can't reproduce problem in my local environment when debugging cn

@joeCarf
Copy link
Contributor

joeCarf commented Dec 9, 2022

And what version is your Mysql? @hadoop835

@hadoop835
Copy link
Author

And what version is your Mysql? @hadoop835

https://github.com/ApsaraDB/galaxyengine 分支main，编译的

joeCarf
joeCarf approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@joeCarf joeCarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussion, i think maybe this failure is caused by local environment, since cn can still start normally without metaDbProp.
However, metaDbProp is still necessary because others may wanna change link properties. That's why i approve this pr

polardbx-server/src/main/java/com/alibaba/polardbx/server/TddlLauncher.java
@@ -165,6 +165,7 @@ private static void initUserAccount(SystemConfig config) throws SQLException, IO

String metaDatabase = config.getMetaDbName();
String innerUser = config.getMetaDbUser();
String metaDbProp = config.getMetaDbProp();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you debuging cn?
I don't understand why these properties are useful here, casue they seems to be defalut settings..
截屏2022-12-08 12 18 46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZSYTY ZSYTY ZSYTY approved these changes

@joeCarf joeCarf joeCarf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hadoop835 @CLAassistant @joeCarf @ZSYTY