Add @_SPI(Internal) to some more navigation apis #3097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex293
force-pushed
the
add-some-internal-spi-to-navigation-stack-apis
branch
from
a08a082
to
8a97ecf
Compare
|
Related to #1674 |
Alex293
changed the title
stephencelis
approved these changes
May 17, 2024
There was a problem hiding this comment.
@Alex293 We chatted about this today and think the impact is minimal enough to take. We do want to caveat that @_spi(Internals) APIs are something we may change/remove at any time, so be aware that your downstream project will need to be aware of changes.
Will merge when green!
|
Yeah I know but TCA + SwiftUI apis are too good to ignore and we are stuck on iOS 15 and might be for a while as it dropped devices. |
|
Also I’d gladly switch to a TCA provided uinavigationcontroller solution if it could support both tree and stack navigation. I couldn’t make your branch work before iOS 16. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on back-porting iOS 16 NavigationStack and every TCA related apis. I managed to make a demo here but I needed to
@testable import ComposableArchitectureThis branch contains the apis required but keep them behind
@_SPI(Internals)as the rest of those apis.