Add ifLet SwiftUI integration warning
#3089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently added a warning when we detect that `forEach` wasn't integrated with a reducer when path elements are pushed or popped from the stack, and I realized that we could do similarly for `ifLet` during dismissal.
mbrandonw
reviewed
May 14, 2024
Comment on lines
+155
to
+157
| action: CaseKeyPath<Action, PresentationAction<ChildAction>>, | ||
| fileID: StaticString = #fileID, | ||
| line: UInt = #line |
There was a problem hiding this comment.
there's probably some DocC references to fix after this...
mbrandonw
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently added a warning when we detect that
forEachwasn't integrated with a reducer when path elements are pushed or popped from the stack, and I realized that we could do similarly forifLetduring dismissal.