Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues/102: Support compression of API response #173

Merged
merged 4 commits into from
May 8, 2024

Conversation

nikki-t
Copy link
Collaborator

@nikki-t nikki-t commented Apr 26, 2024

Github Issue: #102

Description

Enable compression for API Responses

Overview of work done

Modified the Hydrcron API Gateway Terraform and set minimum_compression_size to 20480 as a starting point.

Overview of verification done

Small modification to Terraform, no new units tests required. Existing unit tests pass.

Overview of integration done

Deployed modifications to SIT environment and ran the following queries.

Accept-Encoding=gzip

Confirmed existence of Content-Encoding request header set to gzip.

No Accept-Encoding header

Confirmed that Content-Encoding request header was not present.

PR checklist:

  • Linted
  • Updated unit tests
  • Updated changelog
  • Integration testing

See Pull Request Review Checklist for pointers on reviewing this pull request

@nikki-t nikki-t self-assigned this Apr 26, 2024
@nikki-t nikki-t linked an issue Apr 26, 2024 that may be closed by this pull request
@frankinspace frankinspace changed the title Feature/issue 102 issues/102: Support compression of API response Apr 30, 2024
@frankinspace frankinspace merged commit fd57373 into develop May 8, 2024
1 check passed
@frankinspace frankinspace deleted the feature/issue-102 branch May 8, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable compression for API Responses
2 participants