Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: licenses output table misplaced #8071

Merged
merged 6 commits into from May 15, 2024
Merged

Conversation

btea
Copy link
Contributor

@btea btea commented May 10, 2024

When I run pnpm licenses ls --long under the repository, the printed information as follows.

image

After modification, it is as follows:

image

@btea btea requested a review from zkochan as a code owner May 10, 2024 14:01
@weyert
Copy link
Contributor

weyert commented May 10, 2024

Oh this looks really great! Thank you :D

Copy link
Contributor

@weyert weyert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The console rendering is a bit magical if you ask me

@zkochan
Copy link
Member

zkochan commented May 15, 2024

add changesets, please

@btea
Copy link
Contributor Author

btea commented May 15, 2024

Ok, I have added it.

@zkochan zkochan merged commit 34bc8f4 into pnpm:main May 15, 2024
7 of 8 checks passed
@btea btea deleted the fix/license-detail-format branch May 15, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants