Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: catalogs #8033

Closed
wants to merge 2 commits into from
Closed

feat: catalogs #8033

wants to merge 2 commits into from

Conversation

zkochan
Copy link
Member

@zkochan zkochan commented Apr 29, 2024

No description provided.

@gluxon @zkochan
feat: read catalog configs from workspace manifest (feature flagged) (#…
0056c0a 
…8019)

* refactor: move InvalidWorkspaceManifestError to its own file

* feat: read catalogs config from workspace manifest

* feat: disable catalogs config reads by default

* chore: add changeset for new catalog config parsing
@gluxon
feat: create new @pnpm/catalogs.types package (#8026)
95e9a8d
@zkochan zkochan changed the title feat: read catalog configs from workspace manifest (feature flagged) feat: catalogs Apr 29, 2024
@gluxon
Copy link
Member

gluxon commented May 23, 2024 •
edited

Thanks for starting this. Let me actually rebase the catalogs branch and open a new PR here:

I also want to remove the feature flag on the catalog read commit since we're merging onto a feature branch. No need for a feature flag on a feature branch.

@gluxon gluxon closed this May 23, 2024
@gluxon gluxon deleted the catalogs branch May 23, 2024 22:58
@gluxon gluxon mentioned this pull request May 23, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zkochan @gluxon