Scintilla autocomplete #42

vinsworldcom · 2023-12-07T14:01:46Z

This is just a proof of concept showing it works. Please DO NOT merge this yet. There are still some issues with selection of word to determine autocomplete - it is slow and can lead to over-typing the selection if typing fast. But this does show the concept works.

It would also be nice to have a checkbox ([ ] Use Scintilla Autocomplete) in the settings to enable / disable this feature. You'd have a check of that option in the SCN_CHARADDED:

        case SCN_CHARADDED:
            if (b_UseSciAutoC):
                GTags::SciAutoComplete();
        break;

Fix #41

Cheers.

pnedev · 2023-12-07T15:48:21Z

Thanks @vinsworldcom ,
I'll check that when I find more free time.

Could you please check my example PoC built from this comment: #41 (comment) ?
Thanks again.

vinsworldcom · 2023-12-07T16:00:55Z

Your implementation does not exhibit the word highlighting issue that mine does. I like yours - comments further in #41 (comment)

This still causes the selection to be visible which means it must be calling `getSelection()` still somewhere in the call path for `SciAutoComplete()`

Due to the "Blink the auto-complete word" in 'CmdEngine.cpp'. Create new instructions for `AUTOCOMPLETE_SCINTILLA` and `AUTOCOMPLETE_SCINTILLA_SYMBOL` that do not match that `else if` so no character selection ("blinking") happens.

If not found, we do not want to `ClearSelection()` as that can remove multi- caret. We also want the typed word for autocomplete to be at least 1 character so that `Space` doesn't trigger autocomplete for the full database.

If we're just typing in a file, Scintilla autocomplete is triggered and if there is no local or global database, we don't want to be prompted to create one just based on Scintilla trying to autocomplete.

vinsworldcom · 2023-12-08T22:24:20Z

This PR has been updated to a relatively stable working beta that:

uses integrated Notepad++ / Scintilla autocomplete so does not conflict with multi-caret and actually supports it!
triggers on the 1st typed word-character (this should probably be made configurable)
has an autocomplete icon
does not prompt to create a non-existent database when typing a document in a directory where one does not exist. This is important because database creation should be triggered when one does a menu Autocomplete or any other plugin menu option, but should not prompt when simply typing characters. Think of new document creation in a new directory - there should be no prompt upon first character typed.
does not beep when autocomplete window is visible and typing (though that doesn't really apply, it was an issue with the plugin's autocomplete

Finally, there should probably be an option to disable the feature completely - like checkbox in settings, along with the number of characters to trigger on:

[ ] Use Scintilla autocomplete when typing
[___] Number of characters to type before activating

Cheers.

Fix pnedev#43

Fix pnedev#45

Add icon to results dockable panel

Fix GetFilename() to return the filename without first letter cut-off

This is temporary for testing until a better solution can be added to Settings window. The settings dialog should provide: + [] enable Scintilla autocomplete + [] ignore case + [__] from the nth character The character text box should accept 1-9 as valid characters. Or it could use a slider like the Notepad++ one, though that may be harder to implement. I think autocomplete ignore case should be different than definition and reference ignore case. With Def and Ref, I usually want the exact case match as I see an object in the code, deliberately click on it and then find the Def or Refs of that "exact" (i.e., case-sensitive) object. With autocomplete, I'm getting assitance from the "library" of available objects to help me find what I'm looking for. For example, is the "number of characters": + .length + .len + .Length + .Len + .size + is it a property, or does it end in `()` as a method, etc.. Autocomplete should provide more of a "fuzzy-find" (i.e., case- insensitive) match. Though others may think otherwise so there should be an option to make is case-sensitive, but that option should be different for "autocomplete" vs. "Defs and Refs".

Temporary for testing until adding a proper settings dialog switch.

vinsworldcom · 2023-12-10T15:54:10Z

I think next to work on here is to add a group box in the settings dialog titled Scintilla Autocomplete.

----Scintilla Autocomplete-----------------------------------
|                                                           |
|  [ ] Enable   [ ] Ignore case  [___] From nth character   |
|                                                           |
-------------------------------------------------------------

I'll try that later this week if I get time. For now, I'm running with this as my Notepad++ daily driver to see if any other unexpected issues arise. Looking good so far.

Cheers.

Still no way to add via Settings dialog, but can manually edit the local database config file. Have not yet added the read/write of the integer characters to act on.

Still no way to update in the Settings dialog, but this completes the variable settings required for Scintilla Autocomplete.

Use a pulldown combobox populated with values from 1-9.

vinsworldcom · 2023-12-13T18:07:05Z

I think next to work on here is to add a group box in the settings dialog titled Scintilla Autocomplete.

@pnedev
Done. I think this is relatively stable and ready for a review. I've been using this version in my daily Notepad++ use with no ill effects so far.

Cheers.

pnedev · 2023-12-14T13:49:05Z

Nice Vince, thank you. 👍
I don't promise to merge it (at least it won't be soon since I what to check it and think it over first and this is not on my priority list) but I appreciate your time and effort (and I like it that you have managed to alter the behavior to you liking)

BR and Happy holidays!

vinsworldcom · 2023-12-14T14:36:45Z

I don't promise to merge it (at least it won't be soon since I what to check it and think it over first and this is not on my priority list)

No worries, understood. I'm happy you have a very straightforward build process as I'm able to compile and test my fixes locally. I'm happy to keep running with my altered version now and if you never merge it, I can always pull your changes to get updates, recompile my Scintilla Autocomplete changes locally and run with that.

Thank you for the support, keeping Notepad++ plugins alive and well! Happy holidays to you too!