ROMIO: avoid using global variables, as not thread-safe #6972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move the following global variables defined in ad_tuning.c into
ADIOI_FileD struct as members of a file handle.
int romio_write_aggmethod;
int romio_read_aggmethod;
int romio_onesided_no_rmw;
int romio_onesided_always_rmw;
int romio_onesided_inform_rmw;
int romio_tunegather;
wkliao
added a commit
to wkliao/mpich
that referenced
this pull request
Apr 8, 2024
wkliao
added a commit
to wkliao/mpich
that referenced
this pull request
Apr 9, 2024
wkliao
added a commit
to wkliao/mpich
that referenced
this pull request
Apr 9, 2024
wkliao
added a commit
to wkliao/mpich
that referenced
this pull request
Apr 16, 2024
wkliao
added a commit
to wkliao/mpich
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move the following global variables defined in ad_tuning.c into ADIOI_FileD struct as members of a file handle.
int romio_write_aggmethod;
int romio_read_aggmethod;
int romio_onesided_no_rmw;
int romio_onesided_always_rmw;
int romio_onesided_inform_rmw;
int romio_tunegather;