mpi/misc: Add support for GPU memory allocation kinds #6947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a use-case for this function to be called during MPI init in support the memory allocation kinds feature. Add an MPIR function which bypasses the MPI initialized check.
Add support for querying GPU memory kinds as specified by the current draft of the MPI Memory Allocation Kinds side document (https://github.com/mpi-forum/mem-alloc).
With the addition of CUDA kinds as supported memory allocation kinds, we need to tweak our verification logic slightly. As of today, unless requested by the user, MPICH will always add GPU-related memory kinds at the end of the supported string. Therefore we just check our expected string against the beginning of the returned value using strncmp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Draft implementation of https://github.com/mpi-forum/mem-alloc.
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.