coll: enable topology-aware CVARs in json #6782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dycz0fx
force-pushed
the
json_topo
branch
2 times, most recently
from
4dd2e38
to
34309ec
Compare
|
test:mpich/ch4/gpu |
|
test:mpich/ch4/gpu |
hzhou
reviewed
Mar 1, 2024
|
test:mpich/ch4/gpu |
|
test:mpich/ch4/gpu |
|
test:mpich/ch4/gpu |
|
Note: we need make sure that tests failures are not related. This could be due to the Jenkins node issue, but we need resolve that first before passing this PR. |
|
I will try the tests on main to see if these errors appear. |
|
It seems like these test failures exist in the main branch. I created an empty PR and run test:mpich/ch4/gpu (#6960). The test failures in this PR can be found on that PR as well. |
|
test:mpich/ch4/gpu/ofi |
|
Refer to #6648 (comment) on test failures. |
Allow setting up topology-aware CVARs in collective tuning json file for bcast, ireduce and allreduce.
Add k value when caching the topo_aware and topo_aware_k trees. Add overhead, lat_diff_groups, lat_diff_switches and lat_same_switches when caching topo_wave tree.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Allow setting up topology-aware CVARs in collective tuning json file for bcast, reduce, and allreduce.
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.