Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ch4: enablement on platforms with 8+ nics #6689

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ch4: enablement on platforms with 8+ nics #6689

wants to merge 3 commits into from

Commits on Oct 13, 2023

  1. ch4: lift MPIDI_av_table decl to mpidpre.h 

    Move MPIDI_av_table decl to mpidpre.h so that it has the same visibility
as MPIDI_av_entry

Signed-off-by: Wenduo Wang <wenduwan@amazon.com>
    @wenduwan
    wenduwan committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    34c74aa View commit details
    Browse the repository at this point in the history

  2. ch4/ofi: change MPIDI_OFI_global_t.addrname type 

    MPIDI_OFI_global_t.addrname is used as a single char array, no need to
make it a 2-D matrix.

Signed-off-by: Wenduo Wang <wenduwan@amazon.com>
    @wenduwan
    wenduwan committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    765ae7f View commit details
    Browse the repository at this point in the history

  3. ch4: deprecate MPIDI_OFI_MAX_NICS restriction 

    This patch removes the MPIDI_OFI_MAX_NICS variable which restricts the
max number of NICs that can be used by MPICH.

This change requires changing usages of MPIDI_OFI_MAX_NICS and
converting statically allocated arrays to dynamic arrays. As a result,
malloc and free procredures are added to init and finalize hooks.

This patch retains the current behavior of MPIR_CVAR_CH4_OFI_MAX_NICS,
which by default uses all NICs available from the OFI provider; the
application can restrict the NIC count by setting this CVAR.

Signed-off-by: Wenduo Wang <wenduwan@amazon.com>
    @wenduwan
    wenduwan committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    22ba834 View commit details
    Browse the repository at this point in the history